Skip to content
Submitted 3 months ago

Password generator app

Gwenaël Magnenat•1,290
@gmagnenat
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Password generator app
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

This challenge has stretch my experience with vanilla JavaScript. I did some refactoring to try and optimise my solution with better readability and code organisation.

The next time I want to first list all the interactions, expected actions and expected results before starting to write a line of code. It will probably help to have a better structure from the start.

What challenges did you encounter, and how did you overcome them?

By working on this challenge there was always a lot of questions popping in my head. How do I generate a random string, how to I modify the string to include more characters, how to I calculate the strength of the password?

By doing researches, reading posts, MDN documentation, I usually find the answers to get started and it triggers new questions. It's a constant loop but at least there is a starting point.

What specific areas of your project would you like help with?

I added (to try) a debounce function to reduce the function call and dom update. Is there better ways to do this?

I'm open to any suggestions on code organisation in vanilla JavaScript.

Community feedback

  • Alberto Raúl José•610
    @alberto-rjPosted about 2 months ago

    As for your approach adopted in JavaScript for this solution, I believe it is perfectly readable and organized. I just loved your approach!!

    1
  • Alberto Raúl José•610
    @alberto-rjPosted about 2 months ago

    Hey @gmagnenat, you could fix this issue regarding your social profiles:

    1
  • Alberto Raúl José•610
    @alberto-rjPosted about 2 months ago

    Hi @gmagnenat! I've been taking a look at your solution on github, congrats! I have a question:

    Why did you load the font inline style (between lines 12 to 22 of index.html), instead of external style (style.css)?

    Why? Could you help clarify this, please?

    1
    Gwenaël Magnenat•1,290
    @gmagnenatPosted about 2 months ago

    Hi @alberto-rj , This is a good practice to add the font-style in the head when using custom font. It helps avoid unstyled text at page load if the css file is not loaded. You can check this article on web.dev https://web.dev/articles/font-best-practices

    1
    Alberto Raúl José•610
    @alberto-rjPosted about 2 months ago

    Thanks for your feedback @gmagnenat!!

    0
  • Fatih ŞAHİNBAŞ•520
    @fsahinbasPosted 3 months ago

    Hi Gwenaël, I really like your app. Well prepared project.

    1
    Gwenaël Magnenat•1,290
    @gmagnenatPosted 3 months ago

    @fsahinbas thank you for your feedback ! :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord