Skip to content
OverviewSolutions
11
Comments
7
P
Franklin Gomez
@frankgomezdev

All comments

  • Tsukimi•760
    @hikawiSubmitted 2 months ago
    What are you most proud of, and what would you do differently next time?

    Most proud of the styling to make the cards have a decent width and height, while also being flexible when the screen size doesn't display the grid.

    What challenges did you encounter, and how did you overcome them?

    Had a lot of trouble with max-height and height stuff when trying to make it so cards don't get cut off when it's not in a grid, shouldn't be that difficult but the responsive queries were messing it up a little.

    Testimonials Grid Section

    1
    Franklin Gomez•180
    @frankgomezdevPosted 23 days ago

    Great job!

    No feedback to leave as everything looks amazing. I really love the scrolling and randomize feature that you added to personalize the project.

    Keep up the great work.

    1
  • Mennatalla•90
    @Mennatalla-KhoughaSubmitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    Figuring out the right division for me to use

    What challenges did you encounter, and how did you overcome them?

    Getting the typography as close to the design as possible

    What specific areas of your project would you like help with?

    none

    Four card feature section

    1
    Franklin Gomez•180
    @frankgomezdevPosted 6 months ago

    Not much to write here since you didn't have any questions.

    Very clean and accessible code. Keep up the great work!

    0
  • Franklin Gomez•180
    @frankgomezdevPosted 6 months ago

    Just a few suggestions:

    • For accessibility, your index.html should have a <main></main> tag wrapped around the content, right in between the <body></body> tag.
    • If you put the image in it's own container, you have a little bit more control on the width x height.
    • Try using the font-family suggested to get it closer to what the design looks.
    Marked as helpful
    0
  • Anthony Becarne•160
    @AbecarneSubmitted 7 months ago
    What are you most proud of, and what would you do differently next time?

    At first, I really thought that this challenge was too hard for me to achieve. But I learned new HTML and CSS stuff and I think that the final result is good enough.

    What challenges did you encounter, and how did you overcome them?

    I hardly managed to make it responsive and asked chat gpt for some help :)

    What specific areas of your project would you like help with?

    Any feedback would be appreciated :)

    Recipe page main

    1
    Franklin Gomez•180
    @frankgomezdevPosted 7 months ago

    Great job! My only suggestion would be to work more with the spacing if you want it to look as similar to the design.

    1
  • Franklin Gomez•180
    @frankgomezdevPosted 8 months ago

    My advice and feedback would be:

    1. Be a little more descriptive with your class names.
    2. Try using an <a> tag for the links seeing as they can be clicked and would direct you to a different page.
    3. The color change to yellow should be on the ":hover" state of the links instead of active. (I might be wrong about this, gotta go double check the design).
    4. Take a look into using Flexbox or CSS Grid. Once you understand it, it's way easier to create this layout without having to use fixed heights and widths and pay attention to the padding and spacing between elements.

    Great job and keep up the good work!

    Marked as helpful
    1
  • Mags•270
    @DshizaSubmitted 9 months ago
    What are you most proud of, and what would you do differently next time?

    a

    What challenges did you encounter, and how did you overcome them?

    a

    What specific areas of your project would you like help with?

    a

    blog preview card

    1
    Franklin Gomez•180
    @frankgomezdevPosted 8 months ago

    Very great job! I have no feedback besides checking your HTML to make sure it's semantic. I noticed you have the <main> element inside the .wrapper <div> and not sure if that is correct.

    0
  • Amirreza•270
    @AmirezaMahmoudiSubmitted 10 months ago
    What are you most proud of, and what would you do differently next time?

    This challenge was really easy i tried my best to make my solution as close as possible to the original design.

    What challenges did you encounter, and how did you overcome them?

    this challenge wasn't much of challenge

    What specific areas of your project would you like help with?

    i want to know if i overlooked something

    QR code component

    3
    Franklin Gomez•180
    @frankgomezdevPosted 8 months ago

    I would review the HTML that you used for this. I noticed <main> is sitting inside of a <div> and that doesn't seem right. It's affecting the padding of the content inside, specifically the left & right padding. Fixing this would make your solution look even closer to what the original design is. Great job regardless and I hope you find this helpful!

    Marked as helpful
    2