Submitted 8 months ago

QR code component

Amirreza• 270

@AmirezaMahmoudi

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

This challenge was really easy i tried my best to make my solution as close as possible to the original design.

What challenges did you encounter, and how did you overcome them?

this challenge wasn't much of challenge

What specific areas of your project would you like help with?

i want to know if i overlooked something

Community feedback

Franklin Gomez• 160

@frankgomezdev

Posted 7 months ago

I would review the HTML that you used for this. I noticed <main> is sitting inside of a <div> and that doesn't seem right. It's affecting the padding of the content inside, specifically the left & right padding. Fixing this would make your solution look even closer to what the original design is. Great job regardless and I hope you find this helpful!

Marked as helpful

Amirreza• 270

@AmirezaMahmoudi

Posted 6 months ago

@frankgomezdev Hey thanks for the comment it was just mistake that I made in the beginning of the project and forgot to fix it later thanks for mentioning it

Mihai Chirilov• 140

@MihaiChirilov

Posted 7 months ago

Hi Amirreza, same main comment as Franklin, that <div> holding both <main> and <footer> is weird. Do you have a specific reason for using it? Maybe it is better to remove it. I would also place the footer attribution below the 100vh as it is not part of the design. Or you can simply remove it. I like how clean and simple is your CSS and HTML code. Excellent job! Thank you.

Marked as helpful

Amirreza• 270

@AmirezaMahmoudi

Posted 6 months ago

@MihaiChirilov I corrected my mistake thanks

Mihai Chirilov• 140

@MihaiChirilov

Posted 6 months ago

You are welcome! Keep on working on other challenges and you will improve in no time! It is a long journey but you will be amazed on how much you will accomplish during your journey. We are all walking the same road :) Thank you, Michael

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord