QR code component

Community feedback

• 

  Franklin Gomez•180

  @frankgomezdevPosted about 1 year ago

  I would review the HTML that you used for this. I noticed <main> is sitting inside of a <div> and that doesn't seem right. It's affecting the padding of the content inside, specifically the left & right padding. Fixing this would make your solution look even closer to what the original design is. Great job regardless and I hope you find this helpful!

  Marked as helpful

  2

  ---

  

  Amirreza•270

  @AmirezaMahmoudiPosted about 1 year ago

  @frankgomezdev Hey thanks for the comment it was just mistake that I made in the beginning of the project and forgot to fix it later thanks for mentioning it

  1
• 

  Mihai Chirilov•140

  @MihaiChirilovPosted about 1 year ago

  Hi Amirreza, same main comment as Franklin, that <div> holding both <main> and <footer> is weird. Do you have a specific reason for using it? Maybe it is better to remove it. I would also place the footer attribution below the 100vh as it is not part of the design. Or you can simply remove it. I like how clean and simple is your CSS and HTML code. Excellent job! Thank you.

  Marked as helpful

  1

  ---

  

  Amirreza•270

  @AmirezaMahmoudiPosted about 1 year ago

  @MihaiChirilov I corrected my mistake thanks

  0
• 

  Mihai Chirilov•140

  @MihaiChirilovPosted about 1 year ago

  You are welcome! Keep on working on other challenges and you will improve in no time! It is a long journey but you will be amazed on how much you will accomplish during your journey. We are all walking the same road :) Thank you, Michael

  1