All comments

Steven Noyes•270

@SteveNoyesSubmitted almost 2 years ago

QR Code Component

Franciscus Agnew•10

@franciscusagnewPosted 3 months ago

Hello Steven,

Excellent work on this challenge! Your code is well structured, readable, reusable, and doesn't differ from the design requirements. The only recommendations that I have are that you make provisions for your solution to be responsive for smaller screen sizes as your padding spaces around your image shrink on smaller screens and to make the elements more accessible by maybe inserting your code inside a <main> & <footer> element like so:

<body>
  <main class="qrCard">
    <img src="assets/images/image-qr-code.png" alt="QR code">
    <h1>Improve your front-end skills by building projects</h1>
    <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
  </main>
  <footer class="attribution">
    <p>Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="https://www.frontendmentor.io/profile/SteveNoyes">Steven Noyes</a>.</p>
  </footer>
</body>

Cheers,

Franciscus