Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • @mathematiCode

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm proud of getting the four cards to all be positioned correctly with grid. I had to draw it out to figure out what each grid area would be, but that wasn't too hard with CSS grid. Something I would do differently next time is use CSS grid for each individual card layout as well. I used flexbox but I ran into problems placing the icon in the bottom right corner.

    What challenges did you encounter, and how did you overcome them?

    I couldn't figure out how to place the icon in the bottom right corner of each card. I tried using

    .icon {
    justify-self: flex-end;
    align-self: flex-end;
    }
    

    but that didn't seem to work. I ended up having to create another div within the card div and using flex-grow to make sure that the div extended all the way to the bottom of the card.

    .icon-flex {
        display: flex;
        justify-content: flex-end;
        align-items: flex-end;
        flex-grow: 1;
    }
    

    I think I could have done this more easily with grid.

    What specific areas of your project would you like help with?

    Is there a better way to get the icon to be in the bottom right corner without creating an entirely new div inside of the card div? I'd rather not use padding or translate because I'm not sure that would work well in a more responsive layout. I did try to use translate but it pushed down one icon more than the rest because that card had 3 lines of text and the others had 2 lines. Do you think it's more efficient to use grid or flexbox for the layout within each card?

    P
    Fish Ladder• 140

    @fish-ladder

    Posted

    Hey Julianna,

    I don't think it's necessarily better, but the way I ended up getting the icon to the bottom right was with a display: block; and margin-left: auto;

    And I just stuck with the default flow layout for each card with some padding and a text-align: left; (which I now notice I duplicated for some reason - lol).

    Feel free to check out my code if you want to see specifics: https://github.com/fish-ladder/four-card-feature-section-master

    Hope that helps!

    Joe

    0
  • P
    Arcloan• 280

    @Arcloan

    Submitted

    What are you most proud of, and what would you do differently next time?

    .

    What challenges did you encounter, and how did you overcome them?

    The correct sizing of the element.

    What specific areas of your project would you like help with?

    If someone has any suggestions regarding better css style or anything else i'm open to any suggestions. Thank you very much :)

    P
    Fish Ladder• 140

    @fish-ladder

    Posted

    I think you could tweak the css in a few ways to more closely match the design:

    • adjust the sizing of some elements (avatars, testimonial cards)
    • adjust font sizes and colors (check the style-guid.md file for info about opacity on some of the text)
    • you don't need the solid black border around the cards

    I liked how you used the grid tools to get the desktop layout - nicely done!

    Marked as helpful

    0
  • neven.cebic• 510

    @redizork

    Submitted

    What are you most proud of, and what would you do differently next time?

    none

    What challenges did you encounter, and how did you overcome them?

    none

    What specific areas of your project would you like help with?

    none

    P
    Fish Ladder• 140

    @fish-ladder

    Posted

    Looks good, Neven.

    You could tweak your font sizes and spacing a bit to get closer to the design.

    You might try a max-width on the cards in your mobile design so the don't stretch so much, unless that is the effect you are going for.

    Nice work!

    0
  • P
    mrcordova• 1,120

    @mrcordova

    Submitted

    What are you most proud of, and what would you do differently next time?

    I started with a mobile first approach, I would not change a thing.

    What challenges did you encounter, and how did you overcome them?

    I was having trouble getting the image to take half of the space in the card. I figured out I need to put flex: 1 on the picture element instead of the img element because the picture was a flex item.

    What specific areas of your project would you like help with?

    I welcome any general feedback but one question I had was how to use clamp more effectively. How would I decided what should be the min, best and max and if there some ratio to keep to other text on the screen.

    P
    Fish Ladder• 140

    @fish-ladder

    Posted

    I really liked seeing how you changed the cursor to a pointer - that is a detail I had not noticed before!

    Since your desktop layout doesn't change size anyway, you could probably just use an exact width on your img of half the card size.

    The border radius on your image in the mobile design could probably be tweaked to match the design files a bit more closely.

    Overall, I really like your solution and looking at your code has given me some ideas to use in the future. Thanks!

    Marked as helpful

    1
  • @Luca-Sousa

    Submitted

    What are you most proud of, and what would you do differently next time?

    I needed to study some pseudo-classes to choose the one that was most useful for styling the lists, which led me to research, which added to my studies.

    What challenges did you encounter, and how did you overcome them?

    It was a little more difficult to structure the HTML as well as the CSS, but with the analysis it became clearer how to solve the challenge. The use of lists was something new to use, as was the marker pseudo-class, which I didn't know, but it was very useful for styling the list.

    What specific areas of your project would you like help with?

    At the moment I won't need help, but as soon as something specific comes up, I will certainly seek help.

    P
    Fish Ladder• 140

    @fish-ladder

    Posted

    Hey Lucas, I liked how you used <strong> for the bold parts of the <li> items and your use of flexbox for centering. I think you could tweak some of the colors to more closely match the design (the style-guide gives you the specific color values if you want to use them). Nice work! Joe

    0
  • P
    Julie• 130

    @salentipy

    Submitted

    What are you most proud of, and what would you do differently next time?

    .

    What challenges did you encounter, and how did you overcome them?

    .

    What specific areas of your project would you like help with?

    .

    P
    Fish Ladder• 140

    @fish-ladder

    Posted

    Looks great, Julie. The styling is precise and your CSS is very simple. I like your use of custom properties for the fonts and colors.

    It looks like your img src in your html file doesn't point to the location of the picture file. If you correct the path, your image should show up. Hope that helps.

    Marked as helpful

    0
  • P
    Fish Ladder• 140

    @fish-ladder

    Posted

    You did a great job achieving the styling without nearly as many CSS declarations as I needed!

    Try to find a way to vertically center the card (hint, Flexbox works great for this).

    The border radius, shadow-box, padding, and avatar size could be tweaked a bit to more closely match the design.

    Nice work, overall!

    0
  • P
    Fish Ladder• 140

    @fish-ladder

    Posted

    Nice work, Ashvin! I am very new to web development so I don't feel very qualified to give feedback on your solution but I noticed a couple details I can point out.

    1. Border radius could be tweaked to match the design more closely.
    2. I like your media query and will try something similar in the future.
    3. Could use some more padding between the QR code img and .container
    4. Font-size or font-weight could be tweaked to more closely match the design.
    5. I like how you added an attribution at the bottom - great idea.
    0