Skip to content
OverviewSolutions
7
Comments
1
Federico Durante
@fedementre

All comments

  • Alexandre•20
    @AlexskqSubmitted about 2 years ago

    Hey everyone, I completed this challenge. Can you please check it out and let me know some feedbacks and advices to improve my code.

    Thanks

    Responsive perfume-card

    2
    Federico Durante•70
    @fedementrePosted about 2 years ago

    Hi! Good job, there are a few things you could improve. I'm not very good at it but I can still give you some tips that I hope will help you:

    • Try to put the entire CSS code inside a style document and avoid using inside html, this will help you to put things in order and better identify any errors and possible solutions.

    • excellent use of wrap, sometimes I forget it exists

    • the image appears stretched, try inserting object-fit: cover;

    • the desktop view appears wrong because you have set a high max-width of the media queries, try setting a lower max-width, a mobile device usually has a lower max-width (for example, the iPhone SE has a screen width of 375px)

    For the rest I don't feel like giving any other advice, also because as I said I'm not a super expert, but I hope I've helped you in some way. <3

    1