All comments

• 

  Shibu Sarkar•605

  @shibuwdSubmitted over 3 years ago

  I appreciate any kind of feedback. Please feel free to give me any advice to improve my code.

  

  Easybank landing page

  2

  10
  

  farildsen•55

  @farildsenPosted over 3 years ago

  Hi Shibu,

  Generally I find your code very clean and well written so hats off.

  I have a couple of questions. In your style.css file you commented out the basic reset on line 35-40 containing the "box-sizing: border-box;". Any particular reason for that?

  You have a conditional if-else statement in your app.js. Have you ever considered using conditional ternary operator? Perhaps something like: let toogleImg.src = (isOpen) ? './img/icon-close.svg' : './img/icon-hamburger.svg'

  Anyways keep up the good work!

  Cheers

  Marked as helpful

  0

  This comment has received 3 repliesShow
• 

  Bushra Daoud•65

  @BushraDaSubmitted over 3 years ago

  Thanks for your comments, I solved it.

  

  HTML, CSS, Javascript, Bootstrap

  3

  20
  

  farildsen•55

  @farildsenPosted over 3 years ago

  Hi Bushra, Feel free to browse my repository to see how I chose to solve the tri-state toggle button. If you have any questions I'd be happy to try and answer them to the best of my ability.

  Cheers

  https://github.com/farildsen/farildsen.github.io

  0

  This comment has received 1 replyShow