Easybank landing page

Community feedback

• 

  Ayyaz Ahmed•105

  @ayyaz10Posted over 3 years ago

  Hi Shibu7, I have reviewed your code. All code seems pretty well and the design is looking nice. There are some suggestions I would like to give regarding HTML markup.

  1- No use of header tag: There should be a header tag that will contain the heading section i.e. navigation of the page.

  2- No use of the main tag: There should be the main tag after the header element and all of the section elements should be encapsulated into it.

  3- Semantically and for SEO purposes only one h1 element is considered as best practice. You can use h2 and h3 elements for the lower-level headings.

  I hope these suggestions are helpful. Thank you!

  Marked as helpful

  0

  ---

  

  Shibu Sarkar•605

  @shibuwdPosted over 3 years ago

  @codementee Thank you so much for your suggestions. It's really helpful to me. Thank you again for your time to judge my code.

  0
• 

  farildsen•55

  @farildsenPosted over 3 years ago

  Hi Shibu,

  Generally I find your code very clean and well written so hats off.

  I have a couple of questions. In your style.css file you commented out the basic reset on line 35-40 containing the "box-sizing: border-box;". Any particular reason for that?

  You have a conditional if-else statement in your app.js. Have you ever considered using conditional ternary operator? Perhaps something like: let toogleImg.src = (isOpen) ? './img/icon-close.svg' : './img/icon-hamburger.svg'

  Anyways keep up the good work!

  Cheers

  Marked as helpful

  0

  ---

  

  Shibu Sarkar•605

  @shibuwdPosted over 3 years ago

  @farildsen Thank you so much for the good compliment. Kindly follow this link to know more about box-sizing. https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing

  0

  

  farildsen•55

  @farildsenPosted over 3 years ago

  @Shibu77 I know about box-sizing :) Im wondering why you are choosing not to implement the reset since box-sizing: border-box is a default setting for many. It makes it easier to implement your structural layout with out having to worry about keeping track of adding any border/outlines thickness to your relative element sizes :) I was just curious if you had a reason to do so

  0

  

  Shibu Sarkar•605

  @shibuwdPosted over 3 years ago

  @farildsen Sorry, my bad.

  0