Erika Peterson
@erika-codesAll comments
- @prashrijanSubmitted 3 months ago@erika-codesPosted 2 months ago
Hi @prashrijan! The content itself looks good. However, your content needs to be contained within a container and formatting added in order to replicate the original design. Right now, your content is way too large and the background color is not visible.
Marked as helpful0 - @wasiqurzamanSubmitted 3 months ago@erika-codesPosted 3 months ago
Nice work! Your solution is smaller than the original design though. I too had this same issue and I am not sure how to fix it. I think you did a really great job though!
1 - @EddieBones1Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
One thing that I most proud of when working on this challenge, was the introduction of the global variable function. This function allowed me to code faster in my stylesheet because I was able to refer to the variables that I set for certain properties such as font-size, line-height, and many more.
What challenges did you encounter, and how did you overcome them?One challenge that I encounter was trying to center the attribution under the card in the mobile version. I overcame this by using the inspect tool in my browser to center the attribution, and once I got it center, I was able to input those properties into my stylesheet.
What specific areas of your project would you like help with?One specific area of the project that I would like help with is a faster way to center and lower the attribution under the card, so that I don't have to mess with the properties too much in inspect tool.
@erika-codesPosted 3 months agoOverall, this looks pretty good! The font doesn't display correctly on your live site, so you might want to check that. I think you had problems formatting your attribution because you put the author inside the footer. Only the attribution should be inside the footer.
Also, the box shadow on your card doesn't display correctly in the preview above. Here is how I did mine:
box-shadow: 7px 7px hsl(0, 0%, 7%);
border: 1px solid hsl(0, 0%, 7%);
Hope this helps!
0 - @LFMachucaSubmitted 3 months ago@erika-codesPosted 3 months ago
Nice work @LFMachuca! Remember to always include alt text with your image, and be sure that it is descriptive. This helps with screen readers and also SEO. So, in this case, something like alt="QR code to frontendmentor.io" would work.
Hope this helps!
Marked as helpful0