@OsDroidiSubmitted about 4 years ago
This is the first challenge I have done using pure CSS, I'm still struggling with flexbox and CSS grid, I would appreciate your feedback, Thanks.
Jan
@eljasiuAll comments
- @eljasiuPosted about 4 years ago
Hello, you did quite a good job but I would personally change a few things. I would use 'h2' or 'h3' headings instead of 'p' elements in the top section. In the 'container' you do not need 'justify-content: center', because the child elements take the whole width. And in the 'center' you dont need need it as well, because you wrote 'flex-direction: column'. Have a nice day, keep coding!
1 - @nganbarovaSubmitted about 4 years ago@eljasiuPosted about 4 years ago
Hello, personally I would put #on-top div inside the footer element, and apply "position: relative;" on the footer. It would make positioning the #on-top div easier
0 - @dinakontoSubmitted about 4 years ago
- Was CSS grid the right choice here, or do you think flexbox could have served the design better? 1.2) Could I have made the cards flow into their places more easily, ie without having to manually input their grid positions?
- Is it possible to animate the movement of cards between media queries? I couldn't find a transition property that seemed to work.
@eljasiuPosted about 4 years agoHello, I think that both Grid and Flexbox is a good option in this project. Just depends on your personal preference:-)
0
