Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P
    elCris99 70

    @elCris99

    Posted

    Apart from some measurements that do not match, which is not a problem, the important thing is that you wrote semantic html and responsive css. everything here seems well done, the "original price" with the "visually-hidden" class is a good addition for accessibility

    0
  • P
    elCris99 70

    @elCris99

    Posted

    Hi, good job completing this challenge. Even though I am still very inexperienced, I'll try to leave you some advice that you might find useful:

    1. You should use either padding or margin to avoid that your "containers" touch the lateral edges of the window.
    2. Using "containers" with a maximum size also allows you to avoid that the text lines get too long, this will make your page easier to read. Even if it's not much, I hope you found out it helpful
    0
  • Hieu Tran 40

    @hieutran249

    Submitted

    What are you most proud of, and what would you do differently next time?

    i've learnt to use rem, em

    What challenges did you encounter, and how did you overcome them?

    align divs, responsive

    What specific areas of your project would you like help with?

    responsive

    P
    elCris99 70

    @elCris99

    Posted

    If u find difficult to align divs or to create layout u should practice flexbox and grid. At first u can use some media queries for responsiveness, then maybe u coud learn some more advanced grid concepts.

    0
  • @shojebscodeplay

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am proud of because I understood how from figma I can develop my website easily.

    What challenges did you encounter, and how did you overcome them?

    making it responsive

    What specific areas of your project would you like help with?

    I want reviews to know my quality

    P
    elCris99 70

    @elCris99

    Posted

    A good alternative to the media querys could be using, a max-width and min-width for the card, you can also try to use a clamp() for the font sizes.

    Marked as helpful

    0
  • P
    elCris99 70

    @elCris99

    Posted

    Happy to see other people trying to learn how to use a "design system". Overall your project is similar to the solution.

    0