Skip to content
OverviewSolutions
26
Comments
2
Dubem
@dubemmbah

All comments

  • Dubem•360
    @dubemmbahPosted 9 months ago

    Hello there 👋 @wviie.

    Good job on completing the challenge !

    Your project looks good!

    I have a suggestion that might interest you.

    There is a very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

    I hope this suggestion is useful for future projects.

    Keep up the excellent work and continue to challenge yourself with new projects. Good job on your first submission, each project is a step forward in your front-end development journey! 🚀🌟.

    Other than that, great job!

    Happy coding.

    1
  • Dubem•360
    @dubemmbahPosted 9 months ago

    Your HTML code for the QR code component looks clean and well-structured. Here's some feedback on areas of improvement:

    • Accessibility: You could ensure all images have appropriate alt attributes for accessibility purposes. Alt attributes provide alternative text for screen readers and are important for users who may have difficulty viewing images.

    • Content Structure: The structure of your content is straightforward and easy to understand. However, consider using semantic HTML elements like <header>, <main>, <footer>, etc., to provide more structure and clarity to your document. For example, you could wrap your content inside a <main> element to indicate the main content of the page.

    Overall, your HTML code is well-written and functional. By addressing these points, you can further enhance the accessibility, readability, and maintainability of your code. Keep up the good work!

    0