Responsive web design for QR Code card

Community feedback

• 

  Hassan Moataz•1,860

  @hassanmoaaPosted 9 months ago

  Hello !

  Great Job solving the challenge mate congrats 🎉

  Some suggestions for improvements.

  For the font-size it's is better to use rems and ems. You can’t define it without units.

  font-size: 13px;

  • i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:

  • Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.

  Which properties are affected?

  All of these properties must never ever be declared in pixels:

  • font-size
  • line-height
  • letter-spacing

  If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!

  • You should use ems, and rems for font-sizes would be better

  This article may help:

  https://fedmentor.dev/posts/font-size-px/

  ➖➖➖➖➖➖➖➖

  Use <main> to wrap the main content instead of <div>. * 📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  ➖➖➖➖➖➖➖

  Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.

  <h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>

  Other than that you're good, keep up the good work!

  Marked as helpful

  0

  ---

  

  Surendra Singh•70

  @gusain08Posted 9 months ago

  @hassanmoaa Thanks You for feedback
  i will improve my code structure...

  0
• 

  Dubem•360

  @dubemmbahPosted 9 months ago

  Your HTML code for the QR code component looks clean and well-structured. Here's some feedback on areas of improvement:

  • Accessibility: You could ensure all images have appropriate alt attributes for accessibility purposes. Alt attributes provide alternative text for screen readers and are important for users who may have difficulty viewing images.

  • Content Structure: The structure of your content is straightforward and easy to understand. However, consider using semantic HTML elements like <header>, <main>, <footer>, etc., to provide more structure and clarity to your document. For example, you could wrap your content inside a <main> element to indicate the main content of the page.

  Overall, your HTML code is well-written and functional. By addressing these points, you can further enhance the accessibility, readability, and maintainability of your code. Keep up the good work!

  0

  ---

  

  Surendra Singh•70

  @gusain08Posted 9 months ago

  @dubemmbah Thank You for feedback i will improve my code structure , Accessibility and content Structure,

  0