All comments

• 

  zoe•30

  @alicetang8866Submitted about 1 year ago

  using react, scss,framer-motion,react-router-dom

  

  Newsletter sign-up form reactjs

  1

  20
  

  Manki•150

  @dotmankiPosted about 1 year ago

  A good solution! But it lacks mobile responsiveness, try adding media queries for that.

  0
• 

  Gabriel Novais•30

  @GNovaisLSubmitted about 1 year ago

  Have you know one way to make my code better?

  Did you see errors in my project?

  

  QR code - First Challenge

  2

  61
  

  Manki•150

  @dotmankiPosted about 1 year ago

  hi, your solution is good. Here is my feedback:

  • i see in your code that you are using two media queries, one for desktop and the other for mobile. Personally i follow a mobile first approach and only include desktop media queries
  • i would use CSS variables for color palette to make a more reusable code.
  • the card container is taller than content in desktop viewport, i'd change that height setting to 'auto'

  Marked as helpful

  0
• 

  Del Ara•200

  @MittensdlaraSubmitted about 1 year ago

  

  QR-code Design Component - HTML & CSS

  1

  40
  

  Manki•150

  @dotmankiPosted about 1 year ago

  a great solution! i suggest use CSS variables to make color palette more reusable.

  1

  This comment has received 1 replyShow