QR code - First Challenge

Community feedback

• 

  Manki•150

  @dotmankiPosted about 1 year ago

  hi, your solution is good. Here is my feedback:

  • i see in your code that you are using two media queries, one for desktop and the other for mobile. Personally i follow a mobile first approach and only include desktop media queries
  • i would use CSS variables for color palette to make a more reusable code.
  • the card container is taller than content in desktop viewport, i'd change that height setting to 'auto'

  Marked as helpful

  0
• 

  Renan Rodrigues•960

  @irenanrodriguesPosted about 1 year ago

  Fala Gabriel blz? Recomendo tirar o height: 80%; de .blue-box .qrcode-box. Quando está na versão Desktop, fica um espaço grande em baixo do texto. Mas parabéns pela solução.

  Marked as helpful

  0