Skip to content
OverviewSolutions
6
Comments
6
Donia Elsayed
@donia-elsayed

All comments

  • Donia Elsayed•60
    @donia-elsayed

    need to make more space on the top of the page also the width of cards need to increase a little bit

  • Donia Elsayed•60
    @donia-elsayed

    the font family of the perfume word need to change the h1 Gabrielle Essence Eau De Parfum need to make Gabrielle in a line and Essence Eau in a line and De Parfum in a line

  • Donia Elsayed•60
    @donia-elsayed

    it should have a space above the card that contain all the content need to add pollet points for preparation time points need to add two horizontall lines after ingreduans and instructions for the table need to make the numbers to start from left side

  • Donia Elsayed•60
    @donia-elsayed

    the black background should be for all page the background color of social links like github , linked twitter instgram should be gray color like design not white

  • Donia Elsayed•60
    @donia-elsayed

    need more padding of card to cam make the paragraph appear like in design and the width of card

  • Dimas Abian•10
    @galahad20
    What are you most proud of, and what would you do differently next time?

    I am most proud of the responsive design. In every media quaries added, i add different properties based on the max-width. Making sure that it will be displayed as in the design given. But it display different after i upload it on github pages. Next time, I would plan my code structure better before starting development. While working on this project, I realized that some parts of my code could have been more organized and reusable.

    What challenges did you encounter, and how did you overcome them?

    I faced a lot of problems. Make the card stay at the center even the width or the height change. Don't forget to mention the text inside it, that keep overlapping every media max-width changes. But i manage to overcome it by looking at the tutorials from youtube and similar problems from stack overflow. There also problem when i try to make it appears responsive on mobile size (375px), the container's margin cannot be changed in media (max-width: 375px). After, set the max-width into 376px, it worked. The margin changed.

    What specific areas of your project would you like help with?

    Since i am still new to css, i would like to get to get tips on making responsive pages and what to configure after upload it on github pages. It displayed different.

    QR Code component

    1
    Donia Elsayed•60
    @donia-elsayed

    the only difference between the solution and design there is a lot of space at the bottom of the card and this sentence "Improve your front-end skills by building projects" should be displayed on two lines not three