Skip to content
OverviewSolutions
1
Comments
2
Daria Liferova
@dliferova

All comments

  • SIRSAMUEL014•100
    @SIRSAMUEL014Submitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    Ability to develop a responsive web page.

    What challenges did you encounter, and how did you overcome them?

    I encountered challenge in making the page responsive.

    What specific areas of your project would you like help with?

    Javascript.

    HTML CSS & FLEXBOX

    2
    Daria Liferova•30
    @dliferovaPosted 8 months ago

    Hello, great job! I would advise you

    1. to use semantic HTML markup (such as section, main, etc.), it will help you maintain better organization and improve code readability.
    2. be mindful of having only one h1 heading per page in your markup.
    3. sometimes you style elements based on classes, and sometimes based on ids; it's better to stick to one approach and style elements only by classes.
    4. additionally, avoid using abstract names like id="a" or class="karma"; try to denote the element's semantics through the code, for example, class="karma-card", which immediately indicates that it's a card. You can use multiple classes on one element and eliminate ids, for example, class="card-s karma-card".
    5. I also noticed that the "supervisor" card has a narrower width than the others; it might be something worth correcting.

    Good luck with your future projects!

    0
  • Stefan Holmgren•220
    @stefan-holmgrenSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    It was quite straight forward.

    What challenges did you encounter, and how did you overcome them?

    Grid layout with margins to the edges of the browser took me for a loop, where I couldn't set the content's margin when it also was at a width: 100%.

    I overcame them by adding padding to the container div instead.

    What specific areas of your project would you like help with?

    Not sure about my solution for having margins to the edges of the browser... There's probably a better way.

    CSS Grid

    2
    Daria Liferova•30
    @dliferovaPosted 8 months ago

    Hello,

    Great job! I would suggest providing more detailed naming for classes. For example, if you have

    h1 class="name"

    try to choose names that reflect the entity. In this case, since you're assigning the class to a heading, using class="heading" would be more appropriate than "name".

    Similarly, for <ul class="links",

    a name like "social-links" would be more fitting (since these links are related in meaning).

    Also, just because text on the page is the largest doesn't mean it should be h1. I recommend checking out this article

    Marked as helpful
    0