HTML CSS & FLEXBOX

Community feedback

• 

  Daria Liferova•30

  @dliferovaPosted 8 months ago

  Hello, great job! I would advise you

  1. to use semantic HTML markup (such as section, main, etc.), it will help you maintain better organization and improve code readability.
  2. be mindful of having only one h1 heading per page in your markup.
  3. sometimes you style elements based on classes, and sometimes based on ids; it's better to stick to one approach and style elements only by classes.
  4. additionally, avoid using abstract names like id="a" or class="karma"; try to denote the element's semantics through the code, for example, class="karma-card", which immediately indicates that it's a card. You can use multiple classes on one element and eliminate ids, for example, class="card-s karma-card".
  5. I also noticed that the "supervisor" card has a narrower width than the others; it might be something worth correcting.

  Good luck with your future projects!

  0
• 

  Tatyane Gonçalves•390

  @tatyanepgoncalvesPosted 8 months ago

  Hello,

  For the layout to be responsive you should use media queries and to make it better instead of flex-direction: row; you should have put flex-direction: column;.

  In this link you can find a little about it.

  0