All comments

• 

  Facundo Rubio• 250

  @Facu3071

  Submitted over 2 years ago

  My first challenge completed, i know that it not perfect but i tried it

  

  QR

  2

  50

  

  Dawid Komęza• 180

  @dkomeza

  Posted over 2 years ago

  Hello there! Awesome work with your first project. Viewing at your solution, I would recommend the following for you...

  • You should use em and rem units .Both em and rem are flexible, scalable units.

  For the attribution part I would use:

  .attribution {
  position: absolute;
  bottom: 0;
  left: 50%;
  transform: translateX(-50%);
  width: max-content;
  }
  

  This way the attribution is always centered at the bottom of users device no matter the size.

  Other then that, I think that you should focus on building more responsive designs (using relative width and height, ex. vw, vh). This way every user can see the website in its best form. Nonetheless, good job with this one and keep up the good work.

  Hopefully this feedback helps.

  Marked as helpful

  0