Design comparison
Solution retrospective
My first challenge completed, i know that it not perfect but i tried it
Community feedback
- @dkomezaPosted over 2 years ago
Hello there! Awesome work with your first project. Viewing at your solution, I would recommend the following for you...
- You should use
em
andrem
units .Bothem
andrem
are flexible, scalable units.
For the attribution part I would use:
.attribution { position: absolute; bottom: 0; left: 50%; transform: translateX(-50%); width: max-content; }
This way the attribution is always centered at the bottom of users device no matter the size.
Other then that, I think that you should focus on building more responsive designs (using relative width and height, ex.
vw
,vh
). This way every user can see the website in its best form. Nonetheless, good job with this one and keep up the good work.Hopefully this feedback helps.
Marked as helpful0 - You should use
- @Facu3071Posted over 2 years ago
Thank you very much for your feedback, i really appreciate it.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord