Skip to content
OverviewSolutions
17
Comments
6
DHEERAJ PUJYAM
@dheeraj-90040

All comments

  • Dinesh P•70
    @Dinesh141197Submitted 11 months ago

    Please provide harsh and truthful feedback as much as possible. I want to improve myself significantly.

    Html and Css

    2
    DHEERAJ PUJYAM•200
    @dheeraj-90040Posted 11 months ago

    Great design,

    I like your design because it is unique. Instead of copying, you tried it in your way.

    But there was a small suggestion from my side that you have to improve your design a little bit.

    In your design, you didn't use padding for text content. Use those. Here is the MDN docs on padding; follow this.

    And you also need to know about Flexbox and grid layout. Here are the best resources you can learn from. I hope this was helpful.

    Here are the resources from MDN for learning about padding, Flexbox, and Grid Layout:

    Padding Documentation:
    MDN Padding Documentation: Padding - https://developer.mozilla.org/en-US/docs/Web/CSS/padding

Flexbox:
    MDN Flexbox Documentation: CSS Flexible Box Layout - https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Flexible_Box_Layout
Grid Layout:
    MDN Grid Layout Documentation: CSS Grid Layout -  https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout
    0
  • DHEERAJ PUJYAM•200
    @dheeraj-90040Posted over 1 year ago

    Hello, @JSTong112

    The design you made was absolutely good but they are a few changes that help to Improve your design. The border-shadow has to be changed it is not only spread right & down it is blurred ex - border-shadow: 0px 0px 10px black ;

    This website may help you to make borders as your wish -- > https://shadows.brumm.af/

    -- And the border-radius has to be changed a little bit better use overflow: hidden; [ property ].

    Hope it is helpful , Thank you

    Marked as helpful
    1
  • Daniel Dekany•920
    @dknydSubmitted almost 2 years ago

    Hi Guys,

    Revisited this challenge from a few months ago when I started learning webdev, now I remade it using a deeper understanding of CSS, hope you like it. :)

    As usual, any comments are more then welcome.

    Have a great day y'all!

    Daniel

    Basic layout using flexbox

    1
    DHEERAJ PUJYAM•200
    @dheeraj-90040Posted almost 2 years ago

    Is't really amazing . but do you have any idea about how to avoid Accessibility report errors .

    I have been facing that from last 3 challenges

    0
  • Pedro Beltran•70
    @Alex-Beltran97Submitted almost 2 years ago

    1. I didn't want to create 2 html files to show both desktop and mobile views, so I created a JS script to calculate the resize in the browser to know which image is the right one depending on my browser resolution.

    2. The JS script to listen de resize event

    3. Yes, but I am not sure about a specific question, but I would like to get some information about it.

    / Mock-up-responsive-challenge

    3
    DHEERAJ PUJYAM•200
    @dheeraj-90040Posted almost 2 years ago

    Hi, nice to meet you, The image size is too big and everything is good I think this is your 1st project. so keep learning and practicing. Use flexbox instead for a good look.

    Thank you

    0
  • Dhanya•50
    @dhan5aSubmitted almost 2 years ago

    I am not sure how images from my code can be seen on Github. The image is currently missing in the website. Would appreciate to know more about this!

    There is a small gap below the main picture,which makes the text component a little longer than the picture. I'm not sure how to make both components to be of the same size.

    For the mobile view, the image has been resized, but it looks awkwardly stretched,and there is (again) a small gap between the picture and the text component.

    Desktop-first product preview card component

    3
    DHEERAJ PUJYAM•200
    @dheeraj-90040Posted almost 2 years ago

    I think your image is a source from the desktop. load the image in the folder where u kept the index.html file and give the source directly. then it will take the image and update it in the git repo too.

    thank you.

    Marked as helpful
    1
  • Dhanya•50
    @dhan5aSubmitted almost 2 years ago

    I am not sure how images from my code can be seen on Github. The image is currently missing in the website. Would appreciate to know more about this!

    There is a small gap below the main picture,which makes the text component a little longer than the picture. I'm not sure how to make both components to be of the same size.

    For the mobile view, the image has been resized, but it looks awkwardly stretched,and there is (again) a small gap between the picture and the text component.

    Desktop-first product preview card component

    3
    DHEERAJ PUJYAM•200
    @dheeraj-90040Posted almost 2 years ago

    Hi, Nice meeting you. I saw the problem. I think you used CSS - flexbox and set it to the column direction. what u do is correct. my solution is batter decrease the width of the image and increases the height of the image. and the card width should also increase. that is the problem. and removing wrapping components. try this ma work. or try using bootstrap container

    Thank You

    Marked as helpful
    1