HagarRagab• 190
@HagarRagab
Submitted
Dei
@deidalopez
All comments
- Dei• 60
@deidalopez
Posted
It looks very close, nice job!
I appreciate the way you organized your code, its semantic, and organized. Your sass folder and files are organized and modular, this structure would translate very well to a larger project, so thats great planning.
Marked as helpful
0 - Homey Poon• 60
@homeypoon
Submitted
Dei• 60@deidalopez
Posted
I think you submit the wrong assignment, it looks like the QR assignment.
0 - olatunde victor• 50
@CODE-X19
Submitted
Dei• 60@deidalopez
Posted
Looks very good, but it's smaller than the wireframes.
I recommend setting a max-width instead of definitive width for the card component. And I see you've used rem in other parts of the styling, maybe try rem for width as well!
I like your use of semantic HTML, but you could add a one word descriptor for the img alt to make it more accessible.
0 - ttvclvckPWNERS• 30
@ttvclvckPWNERS
Submitted
What are you most proud of, and what would you do differently next time?
For my project, I'm most proud of the functionality I was able to implement and the way the final product turned out. Seeing everything come together after all the hard work was incredibly satisfying. I learned a lot about problem-solving and how to overcome unexpected challenges, especially when it came to debugging and optimizing the code.
If I could do something differently next time, I would:
- Focus more on planning and documentation from the start. I realized that having a more detailed plan and keeping better records of my decisions would have saved time and made the development process smoother.
What challenges did you encounter, and how did you overcome them?
For this project, I didn’t encounter any significant challenges since the task was relatively straightforward. The ease of the project allowed me to focus more on refining my CSS skills and paying attention to the details, like ensuring the layout was pixel-perfect and responsive.
While there weren’t any major hurdles, I did take the opportunity to experiment with different CSS properties and layouts. This exploration helped me solidify my understanding of CSS, and I feel more confident in my ability to tackle more complex projects in the future.
What specific areas of your project would you like help with?
Since the QR Code Component project was fairly simple and I didn't face any major challenges, I don't need much help with this particular project. However, I’m always looking for ways to improve and would appreciate feedback on:
- Code Optimization: Are there any areas where I could streamline my HTML or CSS for better performance or cleaner code?
- Best Practices: Did I follow best practices in terms of structure, semantics, and accessibility? Any tips on improving in these areas would be helpful.
- Design Enhancements: Are there any subtle design improvements I could make to enhance the user experience or visual appeal?
Getting insights on these aspects would help me refine my approach in future projects.
Dei• 60@deidalopez
Posted
Awesome job, this looks great!
Some really small pointers:
- I noticed theres some divs nested around the same code "<div class="container"><div class="card"> ... </div></div>", could the styling be combined and only need 1 div instead of 2?
- This is a small project, but for larger projects consider storing the colors from the design in variables so you can reuse them (reference: https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties)
Keep up the good work!
0
