Skip to content
OverviewSolutions
3
Comments
5
Debjit Biswas
@debjit

All comments

  • O Grande Soldador•280
    @brendoweSubmitted almost 2 years ago

    Again, I had a little difficulty positioning the elements, but it served as a lesson for further research and I understood better how display blocks, inline and inline blocks work. Other than float and friends.

    Only Media Query

    2
    Debjit Biswas•50
    @debjitPosted almost 2 years ago

    Hey, Grande Soldador, You made a really nice card. Good work. However, I should mention some areas for development. Your card needs to have a margin added to it for mobile so that space can be left around it. For further explanation, watch Kevin Powell's YouTube video, "Responsive Product Card Component - Frontend Mentor Challenge," in which he explains this in great detail. He literally just posted an hour ago. Best of luck for your next challenge.

    1
  • Debjit Biswas•50
    @debjitPosted almost 2 years ago

    Hey, you made a really nice card. Good work. I should however mention some areas for development. Your card needs to have a margin added to it for mobile so that space can be left around it. For further explanation, watch Kevin Powell's YouTube video, "Responsive Product Card Component - Frontend Mentor Challenge," in which he explains this in great detail. Best of luck for your next challenge.

    0
  • Debjit Biswas•50
    @debjitPosted over 2 years ago

    @Ali-Chimim Excellent work. I like your solution, but if you're using react, using inline-style makes more sense when using developement. However, please move inside a class if you are developing for a client.

    It appears that you built this using React. For your upcoming project, I'll suggest using tailwindcss.

    Marked as helpful
    1
  • Debjit Biswas•50
    @debjitPosted over 2 years ago

    You have too much card shadow. Do not add your github profile; only the link to the repository. The title would be better off with padding or a margin.

    0
  • Debjit Biswas•50
    @debjitPosted over 2 years ago

    I really like your solutions. It's pixel-perfect and responsive. Very good work.

    0