Again, I had a little difficulty positioning the elements, but it served as a lesson for further research and I understood better how display blocks, inline and inline blocks work. Other than float and friends.
Debjit Biswas
@debjitAll comments
- @brendoweSubmitted almost 2 years ago@debjitPosted almost 2 years ago
Hey, Grande Soldador, You made a really nice card. Good work. However, I should mention some areas for development. Your card needs to have a margin added to it for mobile so that space can be left around it. For further explanation, watch Kevin Powell's YouTube video, "Responsive Product Card Component - Frontend Mentor Challenge," in which he explains this in great detail. He literally just posted an hour ago. Best of luck for your next challenge.
1 - @SheusVSubmitted almost 2 years ago@debjitPosted almost 2 years ago
Hey, you made a really nice card. Good work. I should however mention some areas for development. Your card needs to have a margin added to it for mobile so that space can be left around it. For further explanation, watch Kevin Powell's YouTube video, "Responsive Product Card Component - Frontend Mentor Challenge," in which he explains this in great detail. Best of luck for your next challenge.
0 - @Ali-ChimimSubmitted over 2 years ago
Is it a good practice to use inline-style?
@debjitPosted over 2 years ago@Ali-Chimim Excellent work. I like your solution, but if you're using react, using inline-style makes more sense when using developement. However, please move inside a class if you are developing for a client.
It appears that you built this using React. For your upcoming project, I'll suggest using tailwindcss.
Marked as helpful1 - @BR-biswadeb-RajSubmitted over 2 years ago
Hello, I have just completed this task. I have just HTML, and CSS. please tell me your opinion.
@debjitPosted over 2 years agoYou have too much card shadow. Do not add your github profile; only the link to the repository. The title would be better off with padding or a margin.
0 - @RosaliaLeySubmitted over 2 years ago@debjitPosted over 2 years ago
I really like your solutions. It's pixel-perfect and responsive. Very good work.
0