Skip to content
OverviewSolutions
23
Comments
7
P

David Mclean

@davuplsOrlando, Fl435 points

Technology geek looking to change my career path into developing web applications and solutions.

Latest solutions

View more solutions

Latest comments

  • P
    David Mclean•435
    @davuplsPosted about 1 month ago

    Looks great! One recommendation is a more descriptive alt for the image.

    An the text inside the links is bold.

    0
  • P
    David Mclean•435
    @davuplsPosted about 1 month ago

    Great job everything looks good. All I recommend is learning variables and writing presets.

    :root {
    --primary-color: #F4D04E;
    --Gray-950: #111111;
    --Gray-500: #686b6b;
}

h1 {
    color: var(primary-color);
}

    This way you can easily change affect the entire UI instead of individually selecting tags to change. An other benefits.

    Marked as helpful
    0
  • P
    David Mclean•435
    @davuplsPosted about 1 month ago

    Recommend updating readme. In the download folder for the project there's a file "Readme.template". Delete the original Readme and then remove the template part of this file. Then go through it to make it your own.

    <div class="main div">  // div is not used

     <p class="first-paragraph">Improve your front-end<br> skills by building projects</p> 

// "first-paragraph isn't a good tag name.
// I understand where your coming from <p> tag but the content inside is not a paragraph
//recommend using a more appropriate tag like <h1> its the title

    img {
    max-width: 100%;  
    height: auto;
    border-radius: 12px;  // 10px
}
// Recommend using the px width & height the size of the image is the same
// for all screen sizes so its easy to implement. Using max-with
// made the image too big

    All in all the design is very close. Great effort!

    0
  • P
    David Mclean•435
    @davuplsPosted over 1 year ago

    Great job with the layout of your design it looks good on all sizes over on my computer.

    CSS 👨‍🎨

    • If you intentionally used Internal CSS then that's okay, otherwise, I would recommend external.
    • The design looks so good, I would put the last effort into getting the button shadows. Here is a CSS Shadow Generator to make it easier: Box Shadow Website
    Marked as helpful
    1
  • P
    David Mclean•435
    @davuplsPosted over 1 year ago

    I would review the website at tablet size: 810w-1080h. The testimonials are squeezed, especially the "Get early access today" section does not look good at all. Looks like your using React, Tailwind etc, which I don't know to tell you what went wrong. Keep up the good work!

    1
  • P
    David Mclean•435
    @davuplsPosted over 1 year ago

    I think you did great on this one. Maybe make the alt text more descriptive for example: "sedan icon". An class name as well example: "more-btn" / "more-link". But good work I understood your code at a quick glance.

    Marked as helpful
    0
View more comments