@akashmishrahahaSubmitted 6 months ago
P
davidmoreau2
@davidmoreau2All comments
- @davidmoreau2Posted 6 months ago
everything looks great except for the size of the element. it looks like you shrunk everything down to a slightly smaller size. i think this may be do to the way you did your @media. build the site so it looks good on mobile or tablets first then size everything up for desktop. code is very clean and easy to read, great descriptive classes.
0 - @AbdulRahmanBoyiSubmitted 6 months ago@davidmoreau2Posted 6 months ago
use margin auto to position the element into the center of the screen. other than that it looks great. correct sizing and colors across the board
0 - @CHBNDJSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
NONE
What challenges did you encounter, and how did you overcome them?NONE
What specific areas of your project would you like help with?NONE
@davidmoreau2Posted 6 months agolooks great, the only issue i see is with view of the hero images on the left and right. I was not able to figure that part out so yours still looks nicer than mine.
0 - @chaithawat21Submitted 7 months ago@davidmoreau2Posted 6 months ago
looks great. code is also very clean, will definitely be book marking your github so i can look through it as an example of what should be done.
0 - @hangtime319Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
In this project I learned a lot about grid layout. It seems like it's an easier layout to adjust than flexbox, but it's limited. I didn't have many difficulties applying responsiveness.
What challenges did you encounter, and how did you overcome them?I found few difficulties applying grid layout. But next time I will use other grid layout resources so I don't need to use media queries.
What specific areas of your project would you like help with?Suggestions on how to simplify the grid layout.
@davidmoreau2Posted 7 months agoVery clean layout. everything looks exactly as it should and i would not make any changes, excellent job. your html is very clean. I did not think to add the two cards in the middle as one div, very smart in my opinion. Build very well that you did not need a lot of code to make it smaller which i am envious of
1 - @yimerahmedSubmitted 7 months ago@davidmoreau2Posted 7 months ago
spot on. make sure to use border radius on the image to get the rounded corners can be written as
img { border-radius: 20px 0 0 20px; }
the order for the numbers is top-left top-right bottom-right bottom-left
you also need increase the font size on the larger site so the text fills the whole screen
0 - @Zwelihlecomet2Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I am mostly proud of everything I have accomplished with this challenge I gave myself a pat in the back because I now see some improvement in me.
What challenges did you encounter, and how did you overcome them?changing the color of the list numbers to the required color, took me some time but I finally knew how to do it with the help from google, and I doubt I'll ever forget it especially since I hassled to know it.
What specific areas of your project would you like help with?media queries
@davidmoreau2Posted 7 months agoLooks awesome. great attention to the spacing of each item on the card. i struggled with getting the color to change on the list numbers. google is a great tool. also use the discord and look in the help section. you can bring up other members code and see how they did it.
0 - @Toluwani-1234Submitted 7 months ago@davidmoreau2Posted 7 months ago
make sure that your main box is a flex box and that you have display flex on the body so you can center it on the screen. The size of the img is too large, make sure to set a max-height and max-width on that. margins between the text is to small. her name and location should be moved up while the quote is moved closer to the links.
Marked as helpful0 - @mayurDayal2000Submitted 7 months ago
- @JosephSamuel-1Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
A more better for centering the element easier and faster
What challenges did you encounter, and how did you overcome them?Centering the element any suggestions or feedback feel free to reach out
What specific areas of your project would you like help with?Aligning the element
@davidmoreau2Posted 7 months agocreating a div underneath the section and going with flexbox may have helped with sizing
0
