@guthierryschiavo
Submitted
Eu não fiz a versão MOBILE ainda por não saber usar Media queries! Mas esse desafio foi um pouco mais difícil de completar.
Danny Gomes
@dannygomes
All comments
- Danny Gomes• 120
@dannygomes
Posted
Está porreiro!
A única recomendação que eu faria é em vez de adicionar tantos valores de padding únicos a cada elemento individual acho que fica melhor removê-los e adicionar um padding geral ao teu div com classe "content".
Experimentei remover o padding do <h1>, do <p> e dos <ul> e depois adicionei um padding: 3rem ao div que tem classe content. Na minha opinião fica mais centrado no div de conteúdo e dá um aspeto mais limpo, simétrico e consistente, até o ficheiro CSS fica mais fácil de ler.
Media queries vai ser relativamente fácil de apanhar o jeito se ja sabes CSS assim. Boa sorte!
Marked as helpful
1 - Jovaughn Bennett• 30
@Jovaughn229
Submitted
I am having difficulties lining up the view icon over the equilibrium icon for when a hover action takes place. How do I stack these images on top of each other? I have commented out what I have so far, would appreciate some feedback.
Danny Gomes• 120@dannygomes
Posted
Hey! I also struggled with the hover image effect. I used a pseudo element to get it done, so I use the hover selector and then use the :after selector on that very same selector to create the pseudo element as the image is hovered. Then it's just a matter of setting the position absolute on the pseudo element and on the parent (I hope I explained myself correctly).
The more experienced developers helped me out with this on the Slack community in the #help channel, if you need help you should join, I really recommend it!
0 - Mo'men Ashraf• 340
@Moamen31
Submitted
Hello, this is my solution for this challenge. I would like your feedback on my code and how to make it better or more clean. Thank you in advance
Danny Gomes• 120@dannygomes
Posted
Hey! It looks pretty clean!
The one suggestion I can give is to put all that content inside a <main> tag. Someone gave me that tip on my first submission so the first thing I do now whenever I start a challenge is add that <main> tag in and add/work on all my content in there that isn't a navbar or a footer.
You got the line height right by the looks of it! I didn't notice the line height on my first submission.
Keep it up!
Edit: Just a quick disclaimer that I am a beginner so if I said anything wrong, please do correct me!
Marked as helpful
0
