Design comparison
Solution retrospective
Hello, this is my solution for this challenge. I would like your feedback on my code and how to make it better or more clean. Thank you in advance
Community feedback
- @dannygomesPosted over 2 years ago
Hey! It looks pretty clean!
The one suggestion I can give is to put all that content inside a <main> tag. Someone gave me that tip on my first submission so the first thing I do now whenever I start a challenge is add that <main> tag in and add/work on all my content in there that isn't a navbar or a footer.
You got the line height right by the looks of it! I didn't notice the line height on my first submission.
Keep it up!
Edit: Just a quick disclaimer that I am a beginner so if I said anything wrong, please do correct me!
Marked as helpful0@Moamen31Posted over 2 years ago@dannygomes Thank you Danny, I appreciate your feedback and I will for sure keep that in mind in my next projects.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord