Skip to content
OverviewSolutions
17
Comments
3
Danny Fong
@dannyfongdev

All comments

  • Danny Fong•410
    @dannyfongdevPosted almost 2 years ago

    This HTML validator does not seem to like Angular generated code. For example, it doesn't like " _ngcontent-ccx-c2".

    0
  • Danny Fong•410
    @dannyfongdevPosted almost 2 years ago

    Your code looks clean and is readable. The only thing I thought in terms of usability, is that you could have disabled the button initially and enabled it after a rating was selected.

    You have all the code available to do this. In function active(), you can take away the disabled attribute.

    The accessibility issues are easy to take care of. Add a <main> and turn your <h3> into an <h1>.

    Good work!

    Marked as helpful
    1
  • Juan Pablo•140
    @JuanPabloYLSubmitted about 2 years ago

    Hi, this is my news homepage

    I build this webpage with pure html and css (mobile-first), I noticed that I must add the functionality of the main menu (toggle), I though that it was just a css and html challenge, so I decide to implement that functionality with pure css code, I would like a feedback about it!!

    News Homepage

    2
    Danny Fong•410
    @dannyfongdevPosted about 2 years ago

    @JuanPabloYL I looked at your code because I liked your transition effect with the mobile menu. I saw also that you used the same navigation bar for mobile. Nice work!

    In the README, it said "bonus" you could use JavaScript, but your way of using CSS only with checkbox way is good!

    Did you see the actives-states.jpg file in the /design folder? I think it must have been an oversight because you did not implment any of the hover effects, which I am sure you know how to do.

    1