Skip to content
Submitted about 2 years ago

News Homepage

Juan Pablo•140
@JuanPabloYL
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...News homepage
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Hi, this is my news homepage

I build this webpage with pure html and css (mobile-first), I noticed that I must add the functionality of the main menu (toggle), I though that it was just a css and html challenge, so I decide to implement that functionality with pure css code, I would like a feedback about it!!

Community feedback

  • Danny Fong•410
    @dannyfongdevPosted about 2 years ago

    @JuanPabloYL I looked at your code because I liked your transition effect with the mobile menu. I saw also that you used the same navigation bar for mobile. Nice work!

    In the README, it said "bonus" you could use JavaScript, but your way of using CSS only with checkbox way is good!

    Did you see the actives-states.jpg file in the /design folder? I think it must have been an oversight because you did not implment any of the hover effects, which I am sure you know how to do.

    1
    Juan Pablo•140
    @JuanPabloYLPosted about 2 years ago

    @dannyfongdev Hi !, thank you so much for your comment I appreciate it. You're right, I didn't pay attention to those details in the documentation :(, I will update it

    1
  • Adriano•38,120
    @AdrianoEscarabotePosted about 2 years ago

    Hi Juan Pablo, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    • We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    The rest is great!

    I hope it helps... 👍

    1
    Juan Pablo•140
    @JuanPabloYLPosted about 2 years ago

    @AdrianoEscarabote Thank you, I will put in on practice!

    1
    Adriano•38,120
    @AdrianoEscarabotePosted about 2 years ago

    @JuanPabloYL happy coding!!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord