Abubakar Tanko• 290
@Abubakar-Tanko
Submitted
Feedbacks are welcomed always :). Thanks in advance
Panewe Daniela
@danielapanewe
All comments
@danielapanewe
Posted
Hello! I will talk about some few points 1- For the color of the image, you could use "background: linear-gradiant(...), url(...)" rather than use an empty div for the color 2- Use right html tags. For example, the tag with the "id = big", it is supposed to be an <h1></h1> or h2 tag because it is is a title 3-Avoid using classname such as "left", "right", it will be difficult to refer yourself when you will be working on bigger project. Make research on "BEM", it will you to well name your classname 4- At some screensize, your image don't feed the container. Put the height of the image at 100% and use a grid for the section with the id="whole"
0- Emanuel Bonardo• 320
@emanuelcba94
Submitted
Feedback welcome. Emanuel Bonardo
@danielapanewe
Posted
Great job! Just two points i will talk about. 1-When you use a div like the div with the classname "flex-one", you don't need to specify "display:block", by default a div has a display:block. 2- For the image you could also put it as a background and use a linear gradient for the color
1 - Bogdan Kim• 780
@semperprimum
Submitted
I would greatly appreciate any feedback you may have!
I've had lot's of problems with with the position of
.share-options, especially on the desktop version.I had to use
!importantso the position properties worked on the desktop version and i have no idea why they would not work without it.@danielapanewe
Posted
Can you tell me where you want to place .share-options so that i can help you
0 - NoobSlayer360• 130
@maksymXlol
Submitted
i did my best i hope it is good :)
@danielapanewe
Posted
That's a great job you did! Don't forget to change the color of these texts ("All", "active", "completed", "clear completed", "drag and drop...") as on the design, the color you put is too white
0
