Design comparison
Solution retrospective
Feedbacks are welcomed always :). Thanks in advance
Community feedback
- @danielapanewePosted over 1 year ago
Hello! I will talk about some few points 1- For the color of the image, you could use "background: linear-gradiant(...), url(...)" rather than use an empty div for the color 2- Use right html tags. For example, the tag with the "id = big", it is supposed to be an <h1></h1> or h2 tag because it is is a title 3-Avoid using classname such as "left", "right", it will be difficult to refer yourself when you will be working on bigger project. Make research on "BEM", it will you to well name your classname 4- At some screensize, your image don't feed the container. Put the height of the image at 100% and use a grid for the section with the id="whole"
0@Abubakar-TankoPosted over 1 year agoThank you for the feedback, I appreciate it @danielapanewe
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord