Skip to content
OverviewSolutions
6
Comments
4
AbdulMalik
@cyberweb8

All comments

  • AbdulMalik•80
    @cyberweb8Posted almost 2 years ago

    Greetings. Good job on completing the challenge. Here is my two cents if you want to improve your code.

    • You must have a level-one heading in a project, even though it is not required to be visible. If it is the case, you can hide visually by applying a class, such as sr-only, and make it visible and readable by screen readers for accessibility reasons.
    • All page content must contain landmarks, since the challenge is not about header, nav, or footer, you can encompass your code withing main tag. More info
    • You have used "border-bottom: .1px dotted hsl(215, 51%, 70%);", however 1px is the smallest unit value one must use. And if you want your border look like in the challenge, you can use solid instead of dotted and 'Very dark blue (line): hsl(215, 32%, 27%)' instead of soft blue as it has given in the style-guide.md file.

    My apologies if I come across as a pedantic person, nothing like that. I just wanted to be helpful.

    Happy coding!

    1
  • AbdulMalik•80
    @cyberweb8Posted almost 2 years ago

    Good job. The match is about 99.7%, I suppose. If you're perfectionist, it means you still have to strive for 0.3% accuracy. If it is not the case, still beautiful job.

    By the way, the extension you've mentioned earlier was 'PerfectPixel' not 'PixelPerfect', right?

    My aplogies, if I come across as someone pedantic. Trust me, I am not. Just want to know if I am working with the same extension. That's all. Buena suerte.

    1
  • AbdulMalik•80
    @cyberweb8Posted almost 2 years ago

    Hey buddy, The link you've provided with is not working. Upon click it directs you to 404 page. You may want to check it out and fix it.

    As for you question, it is all about using semantic html or not. You can have more information here

    0
  • Prithivi Raj•140
    @prithiviraj275Submitted almost 2 years ago

    all feedback's are welcome, please notify my mistakes, that will be more helpful, thanks

    star preview card

    2
    AbdulMalik•80
    @cyberweb8Posted almost 2 years ago
    • To get the image to look like in the example, you can use the mix-blend-mode with the multiply value and include a opacity with the value of 0.8 and the color given in 'style-guide.md' as soft-violet.
    img {
  background-color:hsl(277, 64%, 61%);
  opacity: 0.8;
  mix-blend-mode: multiply;
}

    The statistics info should be built using an unordered list element. More Info about unordered list element:📚The Unordered List element

    I have done like this, just for visualization:

    <ul class="service__details">
            <li class="service__details-companies">
              <p>10k+</p>
              <p>companies</p>
            </li>

            <li class="service__details-templates">
              <p>314</p>
              <p>templates</p>
            </li>

            <li class="service__details-queries">
              <p>12m+</p>
              <p>queries</p>
            </li>
 </ul>

    If you have any questions or need further clarification, feel free to reach out to me.

    Marked as helpful
    0