Simple NFT design

Community feedback

• 

  AbdulMalik•80

  @cyberweb8Posted almost 2 years ago

  Greetings. Good job on completing the challenge. Here is my two cents if you want to improve your code.

  • You must have a level-one heading in a project, even though it is not required to be visible. If it is the case, you can hide visually by applying a class, such as sr-only, and make it visible and readable by screen readers for accessibility reasons.
  • All page content must contain landmarks, since the challenge is not about header, nav, or footer, you can encompass your code withing main tag. More info
  • You have used "border-bottom: .1px dotted hsl(215, 51%, 70%);", however 1px is the smallest unit value one must use. And if you want your border look like in the challenge, you can use solid instead of dotted and 'Very dark blue (line): hsl(215, 32%, 27%)' instead of soft blue as it has given in the style-guide.md file.

  My apologies if I come across as a pedantic person, nothing like that. I just wanted to be helpful.

  Happy coding!

  1

  ---

  

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  @cyberweb8 Thank you for your comment i plan of redoing the challenge again.

  0