Skip to content
OverviewSolutions
19
Comments
7
cucumeris
@cucumerisGIT

All comments

  • cucumeris•260
    @cucumerisGITPosted 2 months ago

    Looks good and responsive.

    1
  • Daniele•300
    @dedo-devSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    There is one thing that makes me proud, is how this solution looks better than the first one on the code side 🥲

    What challenges did you encounter, and how did you overcome them?

    I encountered one challenge on this project, naming variables for the primary colors. Naming things is the harder part of web development 😂

    What specific areas of your project would you like help with?

    I haven't any particular areas where I need help for this challenge but any suggestions are very welcome.

    Thanks ✌️

    Responsive four card feature using CSS Grid

    2
    cucumeris•260
    @cucumerisGITPosted 2 months ago

    Your page looks good and i really like how it matches the original design nearly perfectly. You said that you find it hard to find names for variables but you can reduce the headache if you only declare variables that are used more than once and assign the other values directly to the properties of the elements. Also your page has a little bug in the hero__heading on smaller screens where the heading is not placed on two seperate lines. Your usage of BEM could also benefit if you nest elements and modifiers inside their respective blocks. That would improve readability and maintainability since all related selectors are together at one location but it is just a "can" and not a "must". You should also always include an "alt" in your img/svg elements, otherwise its not accessible. Overall you did a great job with only minor issues. Keep up the work :)

    0
  • cucumeris•260
    @cucumerisGITPosted 3 months ago

    looks good :)

    Marked as helpful
    0
  • cucumeris•260
    @cucumerisGITPosted 3 months ago

    nice

    0
  • cucumeris•260
    @cucumerisGITPosted 3 months ago

    looks good!

    0
  • cucumeris•260
    @cucumerisGITPosted 3 months ago

    nice

    0
  • cucumeris•260
    @cucumerisGITPosted 3 months ago

    Hey, nice work on the QR Code component! Your HTML is clean and well-structured. However, your CSS could use some rework. While nested CSS might work for smaller projects, it can affect readability as projects grow and may cause issues if you need to change the HTML. As far as I tested, the content seems to fit both computer and smartphone screens. Keep up the good work!

    Marked as helpful
    0