Responsive four card feature using CSS Grid

Community feedback

• 

  P

  edpau•440

  @edpauPosted about 2 months ago

  I like your code, they are well structured and easy to read, I can see your effort on naming the variables, I also find it challenging to name the variables for the primary colors. I learnt a lot from your code, thank you.

  Do you think it is better to use article tag for each card, increase semantics?

  0
• 

  cucumeris•240

  @cucumerisGITPosted about 2 months ago

  Your page looks good and i really like how it matches the original design nearly perfectly. You said that you find it hard to find names for variables but you can reduce the headache if you only declare variables that are used more than once and assign the other values directly to the properties of the elements. Also your page has a little bug in the hero__heading on smaller screens where the heading is not placed on two seperate lines. Your usage of BEM could also benefit if you nest elements and modifiers inside their respective blocks. That would improve readability and maintainability since all related selectors are together at one location but it is just a "can" and not a "must". You should also always include an "alt" in your img/svg elements, otherwise its not accessible. Overall you did a great job with only minor issues. Keep up the work :)

  0