Skip to content
OverviewSolutions
7
Comments
6
omisc
@csimomelian

All comments

  • Артем Шомин•80
    @sirnetSubmitted over 3 years ago

    Layout was made according to the picture in two formats mobile 375px and desktop 1440px

    html, css

    1
    omisc•115
    @csimomelianPosted over 3 years ago

    Hey looks clean and great,

    I've noticed that there are an uncontrolled layout from 766px to 1024px that cause horizontal scroll because there are some fixed measurements. Fix it and it will looks perfect.

    Keep coding dude.

    0
  • Bhakskar•110
    @imbhaskarnSubmitted over 3 years ago

    Hey guys this project was fun and challeging.Still i think this project needs some fixing. Building this project i have learned a lot of new things. Any advice will be apreciated.Cheers! Thanks.

    Launch countdown timer

    1
    omisc•115
    @csimomelianPosted over 3 years ago

    Looks great dude! Keep coding, you are in the right way!

    Only take a look to the html issues :D

    0
  • omisc•115
    @csimomelianPosted over 3 years ago

    Yep, looks good. Any challenge, no matter how simple it may seem, has its complications.

    You can increase the line-height value to allow the text breath more, and don't forget to define the alts in the images, is a good pratice.

    1
  • OK169•605
    @olgak169Submitted over 3 years ago

    All animations done with Sass. Would've been much easier and cleaner with JS, but I had to do it the hard way. Leave a feedback, I will be happy to hear your opinion! upd.alignment update

    Css animation using Sass. No JS.

    2
    omisc•115
    @csimomelianPosted over 3 years ago

    The animations are great.

    I would try to avoid using pixel units in favor of rem or em so that it can be more scalable and accessible.

    The text bubbles instead of setting fixed width would be more convenient to use maximum width.

    Rest, good job

    0
  • George•10
    @georgeloweSubmitted over 3 years ago

    Hi,

    Does anyone know why when I use a device with a small screen and my flex-direction is set to column, the cards are off of the screen in the vertical direction?

    Thank you, any advice would please be appreciated

    3-Column Preview Card Component (Flexbox)

    2
    omisc•115
    @csimomelianPosted over 3 years ago

    The height of the content is higher than the height of the body, where normally it should forces the overflow scroll but by having align-item:center or justify-content:center the flex-items do not cause overflow scroll.

    You can figure out with min-height:100vh instead of height:100vh.

    2