@TobiasTroupSubmitted over 2 years ago
I have trouble resizing the image and the div blocks. The image is bigger than the div block wrapped in.
Feedback in general is more than welcome.
Okechukwu Victor chiedozie
@covstarAll comments
- @covstarPosted over 2 years ago
Weldon for completing this challenge. Concerning the image inside the div, make the make width to be 100% for it to be perfectly fitted into the parent container.
Let me know if this was helpful.
Marked as helpful0 - @Cheemma1Submitted over 2 years ago
My solution to frontend mentor QR code component challenge all feedbacks are highly welcomed.
- @terry677Submitted over 2 years ago
In this project, I had difficulty making it mobile responsive. And I would like feedback on how to make a webpage responsive.
@covstarPosted over 2 years agoNice one @terry677. You might still want to remove the HTML texts up, and place your attributions at the footer. Weldon. When you are done with that on GitHub, come back and generate new report and the preview here will be refreshed.
Let me know if this was helpful....
1 - @NickTalvySubmitted over 2 years ago
I found it difficult to get my padding correct for the text. Also, I attempted MQ for tablet and desktop. I feel like I made it harder or more complicated then it needed to be.
I tried to keep accessibility in mind. Please tell me what I could do better, or any best practices I missed.
@covstarPosted over 2 years agoCheck out my code for help.
https://github.com/covstar/qr-code-component-solution
Let me know if it was helpful.
0 - @annachen2Submitted over 2 years ago
Working but atm there is no check that disables the submit button until a rating is selected.
@covstarPosted over 2 years agoIn your javascript, set a condition if the buttons are not already clicked not to submit. E.g; if using jquery $('#submitBtn').click(function(){
Let btn1 = $('#btn1').text(1);
if (btn1 == "") { return false; }
})
What it means, is that if the btn1 is not clicked, the submit button will not work.
Let me know if this was helpful.
0 - @vampmoraSubmitted over 2 years ago
for mob with ok but with big screen it was little tricky for the footer with links, i know its not perfect but its better than the one before :) , if anyone can give me advice about the footer it will be nice :)
@covstarPosted over 2 years ago@vampmora, you did great. Well done.
You can fix the footer links challenge you have by looking up my code, it will at least give you a heads up on what to do.
https://github.com/covstar/clipboard-landing-page-solution
Let me know if this was helpful.
1 - @neuyannSubmitted over 2 years ago
PFewww ... this one was a real challenge... It took so long for me to display correctly the images and the small arrow icons... (which I know I didnt use the correct solution to display).
And, I did my first code in JS.. Quite hard I'd say! There's a problem when i click on the text do display the paragraph down, I need to click two times for it to work. I don't understand why.
Can someone help me to improve my code here? I do need it... Be indulgent, Im just starting coding... Thanks
[UPDATE] I used jQuery for the accordion effect, but how to turn the arrow down in this cas?
Any advice?
@covstarPosted over 2 years agoHave you tried using jQuery. It's much easier than vanilla JavaScript. For example if you want the paragraph to display on click:
HTML:
<div class ="first-paragraph"> <div class="first-heading> <p> your heading to be clicked on</p> </div> <div class="inner-content> <p> paragraph to show or hide on click</p> </div> </div>JavaScript:
$(document).ready(function (){ // Click on the heading to perform a function $('.first-heading').click(function (){
// Will slide the content up or down when clicked once $('.inner-content').slideToggle(); });
})
I hope this is helpful?
0 - @kfadhzSubmitted over 2 years ago
Hi, this is my solution. Any comment for make it better is appreciated. Thank you...
@covstarPosted over 2 years agoUpload only the folders containing to your code, remove it from the single price grid component challenge folder, so that it can be readable by the server.
Marked as helpful0 - @Quake-SilverSubmitted over 2 years ago
Had issues making the site responsive, so I'll be needing your help with that. All feedbacks are welcome
@covstarPosted over 2 years ago@ogunya, I you can try to add ' alt ="" ' to all your image elements to get rid on the Html issues. And you can equally nest your div containers in a 'main ' element after the body element to get rid of the accessibility issues. Thanks
Marked as helpful0 - @AssumptaginikaSubmitted over 2 years ago
I encountered a lot of difficulty in completing this challenge. first was that some of my "img "element did not show when I inputted the "src".
secondly, my project did not respond when i wanted to do the active state. i would appreciate any help i can get from fellow developers so that i can be able to do it better next time.
@covstarPosted over 2 years agoHello Assumpta, you can check out my source code for solution on github. You can play around it. It's easy to access. https://github.com/covstar/nft-preview-card-component-solution
0 - @JshJLVSubmitted over 2 years ago
My first page for frontend mentor
@covstarPosted over 2 years ago@jshJLV you can add a little margin-top to you cantainer, to push down the box a bit.
0 - @EghosaOmuemuSubmitted over 2 years ago
Is there a hierarchy in placing media queries? I realised my media query did not take effect until I positioned it at the end of the CSS code?
@covstarPosted over 2 years agoThere's no hierarchy in placing media queries. All you need to do is to give the right code snippets. As long as your media query starts like this: @media only screen and (min-width:720px){ Body{color:white; } }
There's no hierarchy.
0
