All comments

• 

  amutsamoses• 200

  @amutsamoses

  Submitted 7 days ago

  

  Tip Calculator App

  2

  10

  

  P

  Christina• 190

  @codercreative

  Posted 7 days ago

  Hi @amutsamoses,

  Your Tip Calculator looks awesome!

  I just have a few suggestions:

  Hover State:

  • Add a hover state (lighter green) for the tip buttons and the custom tip button

  Error message for input validation:

  • Even though the design did not specify it, perhaps add an error message if the user does not enter an amount in the bill input field.

  Reset button color:

  • My personal preference: I would either have the reset button be a light cyan color from the get-go -- or make it turn into a light cyan when the user enters data into the input fields for greater user experience.

  Accessibility with fieldset:

  • Also for accessibility, you may consider using fieldset to group related inputs together (I just learned about this myself today)

  Happy Coding!

  0
• 

  Rabel• 190

  @Rabelahmed

  Submitted 15 days ago

  

  responsive time tracking dashboard

  1

  20

  

  P

  Christina• 190

  @codercreative

  Posted 15 days ago

  Hi Rabel,

  I love your solution! 💫

  Perhaps consider...

  -- using switch statements to replace your if statements for better clarity and efficiency.

  -- using template literals to conditionally add an "s" to hrs when the value is not equal to 1.

  -- adding comments in your code and ensuring consistent indentation and formatting for better readability.

  Happy Coding! 🥳

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  P

  Paul Olynek• 330

  @ePaulo

  Submitted 3 months ago

  What are you most proud of, and what would you do differently next time?

  Mobile-first design with extra time spent trying to match all the interactive design notes.

  What challenges did you encounter, and how did you overcome them?

  Had to learn how to open and close dialog modals. Added code reset the form and modal after each useage.

  What specific areas of your project would you like help with?

  I think I got fairly close to the design expectations... other than my decision to place the desktop modal visibly over the Newsletter, ie. instead of placing the modal over a dark-color background (visually by itself).

  

  Newsletter sign-up form with JS error checking & modal success message

  2

  20

  

  P

  Christina• 190

  @codercreative

  Posted 2 months ago

  Hi Paul,

  Christina here from Scrimba -- I am going through the JavaScript Path and your code came up for peer review on my path 😄

  I love your take on the solution, especially how your JavaScript is short, to the point, and very readable.

  Best, Christina

  1
• 

  Annas-khan• 120

  @Annas-khan

  Submitted 3 months ago

  What are you most proud of, and what would you do differently next time?

  got a little hang of JS

  What challenges did you encounter, and how did you overcome them?

  JS part, got help by alex the moderator

  What specific areas of your project would you like help with?

  JS and media query

  

  article-preview

  1

  20

  

  P

  Christina• 190

  @codercreative

  Posted 3 months ago

  Good job! 🎉 With the following small fixes you can convert your project to mobile first and make it responsive: So for example in the class .main-content, add flex-direction: column and then play around with the max-width (e.g. 20rem) in both main and .product-image. Then, add a media query for desktop: @media (min-width: 1024px) { .main-content { flex-direction: row; } main { max-width: 57rem; } .product-image { max-width: 57rem; } } Of course you may need/want to fine-tune further, but hopefully, the small adjustments above will be helpful to you. All the best, Christina

  0