Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P

    @cleyrolsc

    Submitted

    What are you most proud of, and what would you do differently next time?

    I was able to do it in under 3 hours. I thought it was going to take me a lot more to do it.

    What challenges did you encounter, and how did you overcome them?

    How to travel through the DOM, I had to check on some documentation and review some previous courses to get to do it correctly.

    What specific areas of your project would you like help with?

    DOM traversing is an area that I need to keep working on to get better at it

    P

    @cleyrolsc

    Posted

    Hello @ChamuMutezva, thank you very much for the feedback. I highly appreciate it. I will start looking into this things moving forward.

    When it comes to the unit used, usually the desings come with px instead of rems/ems, would it be a good practice to simply convert them, or still use them as instructed?

    0
  • P

    @cleyrolsc

    Posted

    Great job, really liked how the design turned out to be. A couple of things I could've noticed:

    Be more specific with the elements, although you can use div to show any type of text, it would be better if divs are used for container purposes, and then use the respective element for what you are doing... Meaning, for the header use an <h1><h2>, etc... for the paragraph, use a <p> tag instead of using the generic div, that way it is more meaningfull and accessible.

    Responsive layout can also be adjusted. When displaying it in a larger screen, the background color does not stretch all the way.

    0