Esther Atakere• 60
@Esther-Omono
Submitted
Cintia Vicente
@cintiavic
All comments
- Cintia Vicente• 80
@cintiavic
Posted
Looks good!
Marked as helpful
1 - vv• 140
@dblvv
Submitted
What are you most proud of, and what would you do differently next time?
Finally started with css variable.
Don't really know how to use button:hover and :focus.
All should have landmark now.
What challenges did you encounter, and how did you overcome them?
resetting styles again
difference of em and rem
What specific areas of your project would you like help with?
Sizing and scaling
Cintia Vicente• 80@cintiavic
Posted
Looks good to me! As regards to relative units, I suggest this article: https://refine.dev/blog/rem-vs-em/#what-is-css-rem Hope it helps!
0 - ivor-19• 60
@ivor-19
Submitted
What are you most proud of, and what would you do differently next time?
I'm proud of it and I kinda did good.
What challenges did you encounter, and how did you overcome them?
I encounter focus states which I was confused but I'm glad I finish it.
What specific areas of your project would you like help with?
focus states
Cintia Vicente• 80@cintiavic
Posted
It looks good! I had the same issue with the height, I can't make it match the design's. Anyway, a small comment: The card border should be border: 1px solid var(--black-color); border-radius: 20px; box-shadow: 8px 8px;
0 @SoleFernandez
Submitted
What are you most proud of, and what would you do differently next time?
I'm most proud of finishing my first challenge.
What challenges did you encounter, and how did you overcome them?
It was very difficult to me to get the width fixed for desktop layout. I fixed it in 375px.
What specific areas of your project would you like help with?
I'd like some help with the top and the bottom margin in the desktop layout. I'm not happy with my solution when the width grows more than 1500px.
Cintia Vicente• 80@cintiavic
Posted
Hi Sole, I noticed a couple things:
-
The typography is not correct, I think you forgot to import the font in the css file. @import url('https://fonts.googleapis.com/css2?family=Outfit:[email protected]&display=swap');
-
You didn't import your normalize.css from styles.css
-
I highly recommend using Flexbox for the layout, it helps you a lot in terms of responsiveness. You can check my solution if you'd like to.
-
As regards to the width, I chose not to fix the width. Instead, I made the width a proportion of the screen size (using vw units).
I think this will help https://www.w3schools.com/css/css_rwd_intro.asp
Anyway, your solution looks good!!
Marked as helpful
1-
- PEmidio Valeretto• 140
@emidiovaleretto
Submitted
What are you most proud of, and what would you do differently next time?
What challenges did you encounter, and how did you overcome them?
What specific areas of your project would you like help with?
Cintia Vicente• 80@cintiavic
Posted
Cannot access the code, error 404 https://github.com/cintiavic/FMchallenge1.git
0
