Social link profile

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 8 months ago

  Hello @dblvv!

  Your solution looks great!

  📌 Instead of using <button> as list items, it's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

  Here's how you can refactor your code:

  Before Refactoring

      <button>Github</button>
      <button>Frontend Mentor</button>
      <button>LinkedIn</button>
      ...
  

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

  I hope you find this helpful!

  Keep up the excellent work!

  1
• 

  Cintia Vicente•80

  @cintiavicPosted 8 months ago

  Looks good to me! As regards to relative units, I suggest this article: https://refine.dev/blog/rem-vs-em/#what-is-css-rem Hope it helps!

  0