Skip to content
OverviewSolutions
5
Comments
7
Tom Cieslukowski
@ciesluk

All comments

  • Tom Cieslukowski•130
    @cieslukPosted over 1 year ago

    Looks great! Good job! The only thing I would have added is more padding/space between the image and the content on the right.

    Marked as helpful
    1
  • Mel•90
    @devmelodySubmitted over 1 year ago

    I mainly had issues with the sizing. I tried different widths and later had to depend on "inspect" by checking if both sides corresponded. I didn't know how to add fonts or icons at first but I learnt it. It's my first time working with a site like this or doing something like this in general and I plan on improving.

    Product preview card component

    2
    Tom Cieslukowski•130
    @cieslukPosted over 1 year ago

    Hi, good job! Looks great! Few things, don't forget the alt in your image tag. Also, it might have been a bit easier to use the picture tag. https://www.w3schools.com/tags/tag_picture.asp

    Lastly, your design isn't responsive for mobile so practice making media queries and using CSS Grid to style the card. https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries

    Marked as helpful
    0
  • Tom Cieslukowski•130
    @cieslukPosted over 1 year ago

    Looks great! The only thing I would add is a bit more padding in the card around the content! Good job on the component! :)

    0
  • Tom Cieslukowski•130
    @cieslukPosted over 1 year ago

    Hi there! Looks great! Quick tips, don't forget to follow the style guide that is in the folder when you download your challenge. Also, don't forget to use Google Fonts to get the font that matches the challenge. Lastly, remove the bottom <div class="attribution"></div> this is causing some problems in your code.

    0
  • Tom Cieslukowski•130
    @cieslukPosted over 1 year ago

    Congrats! Good job! Looks awesome, they only thing I would change is for your alt be more descriptive.

    1
  • Tom Cieslukowski•130
    @cieslukPosted over 1 year ago

    Good job! Few things I would suggest would be to lower the font-size for the main title to get that extra padding underneath the description. Lastly, instead of <div class="card"></div> you could have used <main> to add some semantic HTML tags.

    Marked as helpful
    1
  • Tom Cieslukowski•130
    @cieslukPosted over 2 years ago

    Looks good! Height could be changed to make it taller and you used the wrong font colour for the description. Finally, the border radius should be a little smaller for the image. Good job! :)

    Marked as helpful
    0