Skip to content
Submitted over 1 year ago

just a simple HTML and CSS

yara-alstouhy•10
@yara-alstouhy
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

any feedback is welcome

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted over 1 year ago

    Hello there 👋. Good job on completing the challenge !

    I have other suggestions about your code that might interest you.

    • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📘.

      Using grid layout

      body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}

card {
    /* margin: 120px auto; */
}
    • You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.

    Font 🔤:

    • It's recommended that you always use the font provided by the challenge's style guide.To import a font, follow the steps below:

      • Go to the font's page on Google Fonts: https://fonts.google.com/specimen/Outfit.
      • A sidebar will appear with a code snippet that you can use to import the font.
      • Copy this code snippet and paste it into the <head> section of your HTML document.
      • Now you can use the "Outfit" font in your CSS by specifying font-family: 'Outfit', sans-serif;.

    I hope you find it useful! 😄

    Happy coding!

    Marked as helpful
    2
  • Tom Cieslukowski•130
    @cieslukPosted over 1 year ago

    Good job! Few things I would suggest would be to lower the font-size for the main title to get that extra padding underneath the description. Lastly, instead of <div class="card"></div> you could have used <main> to add some semantic HTML tags.

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord