MH-WebDev• 150
@MH-WebDev
Submitted
What challenges did you encounter, and how did you overcome them?
Took a little fiddling to understand the JS section of the challenge, as i've not used it before outside of a course on Coursera.
Carina
@cfcmeireles
All comments
- Carina• 150
@cfcmeireles
Posted
Great job with your solution!
If you're open for some feedback:
- For better user experience, you could add "cursor: pointer" to your hover state on your h2 element, this would display a hand when the user hovers each question! You can read more about it here: https://developer.mozilla.org/en-US/docs/Web/CSS/cursor
0 - Loïc Zeiss• 100
@loiczeiss
Submitted
What are you most proud of, and what would you do differently next time?
I'd tweak the css so the data div overlays perfectly the map in all views
What challenges did you encounter, and how did you overcome them?
I found it difficult at first to understand leaflet but after some research it got quite manageable
What specific areas of your project would you like help with?
Using better practices as I find my way of doing pretty messy
Carina• 150@cfcmeireles
Posted
Great job with your solution!
- Have you considered loading the current user's location as soon as the page first loads instead of having an empty div for better user experience? For reference on geolocation API:
"ipAddress Optional. IPv4 or IPv6 to search location by.
If the parameter is not specified, then it defaults to client request's public IP address."
Marked as helpful
0 - Khaled Elorbany• 30
@KhaledElOrbany
Submitted
What are you most proud of, and what would you do differently next time?
I was not sure that I could do it purely with only css and html, but I did :D
What challenges did you encounter, and how did you overcome them?
to write all the code myself with what I learned, without the help of copilot.
What specific areas of your project would you like help with?
None.
Carina• 150@cfcmeireles
Posted
Great job with your solution! I noticed your component was not centered to the page on desktop, this is because you're using a set width of "max-width: 1440px", try replacing that with "width: 100%" and it should be fixed!
0 - Christ Mbuli• 10
@ChristMbuli
Submitted
Carina• 150@cfcmeireles
Posted
Great job with the solution. If I may add some feedback:
- Make sure to use the colors provided in the style-guide file that comes when you download the started files
- Same goes for the assets, the starter files come with an "images" folder with the images you need for the solution (for instance, the image that is displayed after the user submits a number)
- After the submit, you are using the number the user selected on the thank you message, don't forget to also include "[number selected] out of 5" using the highest number to always display after the selected rating
0
