Skip to content
OverviewSolutions
16
Comments
15
Cedrick Garcia
@cedgarcia

All comments

  • Cedrick Garcia•905
    @cedgarciaPosted over 3 years ago

    Hi, Samuel Fuch!

    Well done on this challenge! Your code is clean. I suggest you to add a max-width property in your main to make it look better(it stretches too much on a bigger screen ). Overall Goodjob. (add max-width:1400px; in your main)

    2
  • Aldair Avalos•50
    @AMLO-BotSubmitted over 3 years ago

    I would love having feedback about the implementation of BEM arquitecture for this project. I reaaly think there is a lot of space for improvement and Im just a newbie so I do not know really what Im doing. Appreciate in advance your comments

    Newbie profile card, used semantic HTML and BEM CSS

    2
    Cedrick Garcia•905
    @cedgarciaPosted over 3 years ago

    As a newbie, your code looks great. Try to minimize your usage of a double dash(--) in naming classes because it might make someone confuse, and your CSS code will look messier(especially if you will use variables in CSS). You can check my solution here: (https://cedgarcia-front-end-mentor-solutions.vercel.app/1_profile-card-component-main/index.html), GitHub repo(https://github.com/CedGarcia/FrontEndMentorSolutions/tree/master/1_profile-card-component-main). Overall Good Work

    2
  • Cedrick Garcia•905
    @cedgarciaPosted over 3 years ago

    Good Job. Your design looks perfect and your code is clean. Just try to separate your css code next time. Kindly follow me on github. Thank you

    0
  • Cedrick Garcia•905
    @cedgarciaPosted over 3 years ago

    Good job. Your code looks clean. If you want to learn more, kindly follow my github account You can see my solutions in there

    0
  • Wiktor•20
    @wiktorpagaczSubmitted over 3 years ago

    This is my first challenge on this page and my first responsive design. I'd love to get some feedback and advice

    Responsive layout using floats

    1
    Cedrick Garcia•905
    @cedgarciaPosted over 3 years ago

    Good Job on your first challenge. Try to use Relative Units e.g. (vh,vw, rem ,em) for a better responsive design

    1
  • Cedrick Garcia•905
    @cedgarciaPosted over 3 years ago

    Good job. Your code is clean. Keep it up

    0
  • Cedrick Garcia•905
    @cedgarciaPosted almost 4 years ago

    Good job on your first attempt. Just add a "background-repeat:no -repeat;" on your styling. It seems that you did'nt use the "bg-pattern-bottom.svg". Try to add it by doing this:

    body { background-image: url(images/bg-pattern-top.svg), url(images/bg-pattern-bottom.svg); background-repeat: no-repeat; background-size: 800px; background-color: rgb(0, 182, 199); }

    5
  • Jamie Wales•90
    @Jamie-WalesSubmitted almost 4 years ago

    Only just started learning front-end development after a few years of being in a client services team, looking to jump over so feed appreciated :D

    Profile Card - HTML + CSS

    1
    Cedrick Garcia•905
    @cedgarciaPosted almost 4 years ago

    Good Job, Positioning of background is always hard. Your code is clean Just deep dive on media queries to make it responsive

    4
  • Cedrick Garcia•905
    @cedgarciaPosted almost 4 years ago

    Good job. Your code is clean. Just remove the "scrset" (<img src=images/icon-supervisor.svg alt=Calculator Icon srcset=``>)

    4
  • Eskender•65
    @egxperienceSubmitted almost 4 years ago

    All kind of feedback highly appreciated as initially didn't get idea how to start the project. All job done mixing vanilla CSS and Bootstap codes and would like to get feedback on "photo" and "stats" code (it was not easy to make it working at the beginning)

    Bootstap 5, MDN CSS Tutorial

    1
    Cedrick Garcia•905
    @cedgarciaPosted almost 4 years ago

    Good work! You just need to adjust the bottom-background to right.

    4
  • Yagiz•140
    @tosbaaSubmitted almost 4 years ago

    Hello, this is my first example that i solved for this website. I'm waiting for the feedbacks. Thank you !!

    Profile Card with Flex And Grid

    2
    Cedrick Garcia•905
    @cedgarciaPosted almost 4 years ago

    Try to resize your Card, and follow the colors given by the guide. Your code looks clean. Specially the profile-stats

    4