Newbie profile card, used semantic HTML and BEM CSS
Design comparison
Solution retrospective
I would love having feedback about the implementation of BEM arquitecture for this project. I reaaly think there is a lot of space for improvement and Im just a newbie so I do not know really what Im doing. Appreciate in advance your comments
Community feedback
- @cedgarciaPosted over 3 years ago
As a newbie, your code looks great. Try to minimize your usage of a double dash(--) in naming classes because it might make someone confuse, and your CSS code will look messier(especially if you will use variables in CSS). You can check my solution here: (https://cedgarcia-front-end-mentor-solutions.vercel.app/1_profile-card-component-main/index.html), GitHub repo(https://github.com/CedGarcia/FrontEndMentorSolutions/tree/master/1_profile-card-component-main). Overall Good Work
2@nicolasdsaPosted over 3 years ago@cedgarcia I didn’t do this project but thank you very much for putting your solution in the comments, I always have a lot of difficulty with the responsiveness of the background image, I didn’t know this way you used it, I’ll research more about how to use it correctly and start using it. sorry for my english, my first language is not english
1 - @Will-1-AmPosted over 3 years ago
Nice work! Check out the report above for some easy fixes to the code. Keep on coding ;-)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord