Skip to content
OverviewSolutions
5
Comments
3
Cássia
@casbern

All comments

  • Cássia•90
    @casbernSubmitted over 3 years ago

    What do you guys think I need to improve in my code?

    For some reason I have difficulties using the semantics on HTML, I would like to know what could I do to make my code more semantic? In this case where I had only the cards, what tags I should have implemented?

    Any feedbacks will be welcome!

    Thanks you very much.

    3 column layout site made using flexbox

    4
    Cássia•90
    @casbernPosted over 3 years ago

    Ah... Muito obrigada pelo retorno mais uma vez e pela ajuda. Agora tá bem mais claro pra mim.

    0
  • Cássia•90
    @casbernSubmitted over 3 years ago

    What do you guys think I need to improve in my code?

    For some reason I have difficulties using the semantics on HTML, I would like to know what could I do to make my code more semantic? In this case where I had only the cards, what tags I should have implemented?

    Any feedbacks will be welcome!

    Thanks you very much.

    3 column layout site made using flexbox

    4
    Cássia•90
    @casbernPosted over 3 years ago

    I also got this accessibility issue that I do not understand how to solve it.

    Do you know what this means "All page content should be contained by landmarks "?

    0
  • Cássia•90
    @casbernSubmitted over 3 years ago

    What do you guys think I need to improve in my code?

    For some reason I have difficulties using the semantics on HTML, I would like to know what could I do to make my code more semantic? In this case where I had only the cards, what tags I should have implemented?

    Any feedbacks will be welcome!

    Thanks you very much.

    3 column layout site made using flexbox

    4
    Cássia•90
    @casbernPosted over 3 years ago

    Hi Joel.

    Thank you very much for your answer. =)

    I will implement the section tag in my code. I think you are right on that and I got it now. I am still having problemas implementing semantics for some reason.

    I forgot to ask.. Do you think I used BEM correctly?

    Another question I have is related to the tags <button> and <a>. Because I did a bit of research and that is the reason why I chose the tag <a> instead of <button>.

    They say the <a> should be used when the button is a link to the content of the page or external content. And the <button> should be used to create buttons on the page, like when you need an action like onClick(). I took this info from a medium article and that is why I went for the <a>. Maybe I should have added a role attribute to specify that was a button, because this "learn more" will probably lead to another page or even to another part in the same page, right?

    Another thing is I always thought we should start a heading tag with <h1>. Is there a place from where you took this info that I could also read? Because I know they are important from SEO. I also have difficulties while using these heading tags that is why I ask.

    I really appreciate your help. Obrigada. =)

    0