Skip to content
OverviewSolutions
7
Comments
3
Andrew
@cartaplassa

All comments

  • mkhantk•200
    @mkhantkSubmitted 29 days ago
    What are you most proud of, and what would you do differently next time?

    It's alright.

    What challenges did you encounter, and how did you overcome them?

    trying the hover effects without group hover, eventually use group hover

    What specific areas of your project would you like help with?

    any suggestions? Thanks.

    Responsive landing page with mobile first aporoach

    1
    Andrew•130
    @cartaplassaPosted 20 days ago

    The app seems quite large as a single component, is that a personal preference? Anyway, I have a suggestion at modularizing it and removing some boilerplate code, check PR. Other than that, good job!

    Marked as helpful
    0
  • khalagai•390
    @khalagaiSubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    This is my first multi-page website. I started the challenge desktop-first which turned out to be quite hectic. I will definitely begin my challenges mobile-first from now on.

    What challenges did you encounter, and how did you overcome them?
    • Getting the curtain navigation menu right was a bit confusing but a page on w3schools helped.
    • Adjusting the font size to the different screen sizes was also a challenge. I used the "clamp" method which helped but I think it could be better. Any tips?
    What specific areas of your project would you like help with?

    I would appreciate any feedback to improve my first attempt at a multi-page website.

    loopstudios-landing-page-main

    1
    Andrew•130
    @cartaplassaPosted 23 days ago
    • <br> tag usage is discouraged (Reason), you could use &#013; or other options, but personally I love putting &nbsp; in places where NOT to break lines.
    • For adjusting font-size there's an option of setting it relative to viewport (vh/vw units), or better yet look into CSS Container Queries
    • Styling the .create-photos grid must have been painful, but grid is actually a lot easier to deal with. I made a PR with some changes, take a look.
    • What was the purpose of this structure: <a href="#home">A<span>bou</span>t</a>

    There are different text colors in footer's original design, the abyss between header and notes in info section could be several times shorter, other than that lgtm, good job

    0
  • HL Wong•290
    @hl-wongSubmitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    So far for now I have learned the methodologies and architectures from Frontend Mentor "Advanced CSS techniques", and I have applied BEM (Block, Element, Modifier) with SASS in this challenge.

    What challenges did you encounter, and how did you overcome them?

    I think it been a long time that I didn't use SASS, and forgot how to use it. I searched some article example like Medium, CSS-Tricks on how to use BEM with SASS.

    What specific areas of your project would you like help with?

    I'm not sure I applied the right way of BEM (Block, Element, Modifier) in this challenge. Feel free to give feedback if I applied the wrong way.

    NFT preview card component using BEM and SASS

    1
    Andrew•130
    @cartaplassaPosted about 2 months ago

    Everything's great, except BEM components are not divisible. There are two approaches to fix that: restructurize the card block, so that each component has a unique name, or separate the component into its own block. Eg. with card__content__info__ethereum that'd be either card__etherium-icon or price__icon respectively.

    Edit: you can use both at the same time, but as different classes.

    1