All comments

• 

  mucahitozturkes• 330

  @mucahitozturkes

  Submitted 6 months ago

  

  responsive site mobil to desktop

  1

  20

  

  P

  Carolina Semeao• 110

  @carolsemeao

  Posted 5 months ago

  The solution could be improved. What you should definitely consider, is working with more HTML elements like <p>. Semantic-wise the headings hierarchy doesn't quite make sense. You completely skipped over <h1> and <h2>. I'd use <h1> instead of your <div class="header">. Here's what I did:

  <h1>
    Reliable, efficient delivery
    <span>Powered by Technology</span>
  </h1>
  

  As for the <h2>, I used them in the cards themselves. Like this:

  <div class="card card--supervisor">
     <h2>Supervisor</h2>
     <p>Monitors activity to identify project roadblocks</p>
  </div>
  

  As for the layout it looks nice! It doesn't differ much from the original design. Your code per se is fine. Try looking into the BEM-methodology for naming CSS classes. This will give your code even more structure.

  We all start somewhere and I hope this feedback finds you well and helps you improve your skills :) Good luck!

  Marked as helpful

  0
• 

  P

  gabrieltrtl• 580

  @gabrieltrtl

  Submitted 6 months ago

  What are you most proud of, and what would you do differently next time?

  I'm proud because I finished this challenge very quickly, I wouldn't change anything, maybe I would just use some css functions like clamp()

  What challenges did you encounter, and how did you overcome them?

  I didn't encounter any difficulties with this challenge.

  What specific areas of your project would you like help with?

  No part of this challenge made me need help

  

  Product Preview Card Component

  1

  30

  

  P

  Carolina Semeao• 110

  @carolsemeao

  Posted 5 months ago

  The solution includes semantic HTML and is accessible. In my opinion, I don't see chances for improvement, because I think it's very good. Your code is very well structured and doesn't differ much from the design. Good job!

  0