responsive site mobil to desktop

Community feedback

• 

  P

  Carolina Semeao•110

  @carolsemeaoPosted 8 months ago

  The solution could be improved. What you should definitely consider, is working with more HTML elements like <p>. Semantic-wise the headings hierarchy doesn't quite make sense. You completely skipped over <h1> and <h2>. I'd use <h1> instead of your <div class="header">. Here's what I did:

  <h1>
    Reliable, efficient delivery
    <span>Powered by Technology</span>
  </h1>
  

  As for the <h2>, I used them in the cards themselves. Like this:

  <div class="card card--supervisor">
     <h2>Supervisor</h2>
     <p>Monitors activity to identify project roadblocks</p>
  </div>
  

  As for the layout it looks nice! It doesn't differ much from the original design. Your code per se is fine. Try looking into the BEM-methodology for naming CSS classes. This will give your code even more structure.

  We all start somewhere and I hope this feedback finds you well and helps you improve your skills :) Good luck!

  Marked as helpful

  0